-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to send emails to private domain owners #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maciej-szlosarczyk
force-pushed
the
registry-824
branch
2 times, most recently
from
May 23, 2018 06:48
70a5923
to
f38bb05
Compare
TODO: Add mailer and handling of mails Add handling of IP addresses Add stripping of unsafe text in email
maciej-szlosarczyk
force-pushed
the
registry-824
branch
from
May 23, 2018 07:05
940ee32
to
faee574
Compare
JSON for private person now includes additional field, this info should be communicated to voog:
Other than that, this is up for testing, please pay attention to text as there are some gaps in translation, and if you find any translation that is off/missing, make a comment here. I'll add them accordingly. |
- deleteCandidates - reserved - blocked
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can be merged already
The following new variables are needed on staging and then production:
We most likely can copy the values from registry, except for
mailer_from_address
andmailer_host
, which are new variables.mailer_host
is very important to set up properly, otherwise the links in emails direct people to wrong places.