Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PB-1031] fix: return only base if path comes from a folder #386

Open
wants to merge 1 commit into
base: feat/win-sync-engine
Choose a base branch
from

Conversation

apsantiso
Copy link

  • Prevent extract last letter from a folderPath that contains multiple dots.

@apsantiso apsantiso added the bug Something isn't working label Oct 2, 2023
@sonarcloud
Copy link

sonarcloud bot commented Oct 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@apsantiso apsantiso changed the title fix: return only base if path comes from a folder [PB-1031] fix: return only base if path comes from a folder Oct 2, 2023
@@ -17,7 +17,7 @@ export class FolderPath extends Path {
return 'Internxt Drive';
}

return super.name();
return super.name(true);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the logic is not the same for all Paths (files and folders) I would rather not call the parent class and return here path.basename(this.value) as we already know it's folder because we are in a FolderPath method. Nevertheless, looks good to me to merge

@JoanVicens JoanVicens self-requested a review October 3, 2023 11:48
@JoanVicens
Copy link
Contributor

Tried the changes with the app, but seems like that was not the issue

@apsantiso
Copy link
Author

Tried the changes with the app, but seems like that was not the issue

Maybe you´re testing a flow I didn´t test?
I tested either creating the folder directly from Internxt folder and moving a folder from another location to the app.

If these are the cases you tried, can you try running yarn build before testing it? For some reason I was not able to see any changes until I did that before running yarn start

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants