Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for logging #225

Merged
merged 2 commits into from
Sep 9, 2021
Merged

Conversation

riedgar-ms
Copy link
Contributor

Discovered via an import of the responsibleai package, a library package shouldn't call logging.basicConfig(). That logging call is really only meant to be called once per process:

This function does nothing if the root logger already has handlers configured, unless the keyword argument force is set to True.

If a user calls logging.basicConfig() after import dice_ml, they probably aren't going to get the log messages they expect.

Signed-off-by: Richard Edgar riedgar@microsoft.com

Signed-off-by: Richard Edgar <riedgar@microsoft.com>
Signed-off-by: Richard Edgar <riedgar@microsoft.com>
@gaugup gaugup merged commit ea97c91 into interpretml:master Sep 9, 2021
@github-actions
Copy link

github-actions bot commented Sep 9, 2021

Unit Test Results

    1 files  ±0      1 suites  ±0   11m 6s ⏱️ ±0s
199 tests ±0  195 ✔️ ±0  4 💤 ±0  0 ❌ ±0 

Results for commit ea97c91. ± Comparison against base commit ea97c91.

♻️ This comment has been updated with latest results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants