Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix gated builds due to getargspec deprecation #570

Merged
merged 1 commit into from
Jul 20, 2023

Conversation

imatiach-msft
Copy link
Collaborator

Gated builds seem to be failing due to error when calling inspect.getargspec in tests:

2023-07-18T22:15:32.9356507Z         if kwonlyargs or ann:
2023-07-18T22:15:32.9356904Z >           raise ValueError("Function has keyword-only parameters or annotations"
2023-07-18T22:15:32.9357273Z                              ", use inspect.signature() API which can support them")
2023-07-18T22:15:32.9358074Z E           ValueError: Function has keyword-only parameters or annotations, use inspect.signature() API which can support them

See build:
https://pipelines.actions.githubusercontent.com/serviceHosts/c1806717-186f-43d1-b5bb-864035754060/_apis/pipelines/1/runs/1655/signedlogcontent/3?urlExpires=2023-07-19T13%3A49%3A56.8756087Z&urlSigningMethod=HMACV1&urlSignature=n7yT0tLu9c5kxVKqapcs71ABVMRu34O077hYnZORsVs%3D

According to similar issue:
treethought/flask-assistant#89

The reason for this is that [inspect.getargspec](https://docs.python.org/3/library/inspect.html#classes-and-functions) can't handle type annotations and is deprecated in favor of inspect.getfullargspec. According to the documentation the latter should be a drop-in replacement, but this should probably be tested.

Hence, using inspect.getfullargspec as a drop-in replacement for the previous method to resolve the build errors.

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (3d67671) 87.70% compared to head (cd840bd) 87.70%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #570   +/-   ##
=======================================
  Coverage   87.70%   87.70%           
=======================================
  Files          62       62           
  Lines        4075     4075           
=======================================
  Hits         3574     3574           
  Misses        501      501           
Flag Coverage Δ
unittests 87.70% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...interpret_community/mimic/models/lightgbm_model.py 86.51% <100.00%> (+0.56%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@imatiach-msft imatiach-msft merged commit a4b2626 into interpretml:main Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants