Permit Modify Server-side Workspace Folder... before connection becomes active
#1477
Conversation
| @@ -606,7 +606,7 @@ | |||
| }, | |||
| { | |||
| "command": "vscode-objectscript.modifyWsFolder", | |||
| "when": "vscode-objectscript.connectActive && resourceScheme =~ /^isfs(-readonly)?$/ && explorerResourceIsRoot && !listMultiSelection", | |||
There was a problem hiding this comment.
Removing the vscode-objectscript.connectActive check is fine, but why remove the resourceScheme one?
There was a problem hiding this comment.
Because resourceScheme is undefined if you haven't opened a file yet. And in any case the file you've got open might not come from the root whose settings you're trying to alter.
There was a problem hiding this comment.
That sounds really strange to me. I just opened my .code-workspace file with two isfs folders. No files have been opened besides the "welcome" webview that opens automatically. The Modify server-side workspace folder... context menu option is present. Are those not valid reproduction steps?
There was a problem hiding this comment.
Try starting with no workspace, then add a folder from Server Manager.
There was a problem hiding this comment.
Ok, now I can see it. This seems like a bug in VS Code though. The resource* context keys should be set to the Uri of the explorer tree item when you open the context menu. That works for saved workspaces upon open, but doesn't for untitled workspaces unless you open the folder that was just added.
There was a problem hiding this comment.
It seems that the resource* context keys for a root folder are missing when it's a single-root workspace but are present when it's multi-root.
There was a problem hiding this comment.
Can we report this as a bug with the VS Code team? I'm fine with removing the "connectActive" check but I don't like adding this menu option for all workspace folder roots if we don't have to.
There was a problem hiding this comment.
I plan to report it. Meanwhile I've tweaked my change.
This PR fixes #1476