Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow serverForUri to return password for unnamed server (#837) #838

Merged

Conversation

gjsjohnmurray
Copy link
Contributor

This PR fixes #837

@isc-bsaviano please use the dev VSIX to verify that this meets the need without exposing passwords that may have come from Server Manager's authentication provider.

@gjsjohnmurray
Copy link
Contributor Author

@isc-bsaviano sorry, there's no dev VSIX until #839 gets approved by @daimor and added to this branch.

@gjsjohnmurray
Copy link
Contributor Author

@isc-bsaviano the CI for the prerelease branch is now in place and has built a dev vsix at https://github.com/intersystems-community/vscode-objectscript/suites/5069595553/artifacts/150724470

Please install it manually (e.g. by dropping it onto the Extensions view) and test it meets the need identified in #837 without exposing passwords in other situations.

Be aware that it won't show as a pre-release in the Extensions view in the way it would if installed from Marketplace (see microsoft/vscode#140949 (comment) for why). To prove it was packaged using the --pre-release switch you can rename the vsix to have a .zip extension, look inside it, examine the extension.vsixmanifest file, and confirm the presence of this:

<Property Id="Microsoft.VisualStudio.Code.PreRelease" Value="true" />

@gjsjohnmurray gjsjohnmurray merged commit 0171f83 into intersystems-community:prerelease Feb 3, 2022
@gjsjohnmurray gjsjohnmurray deleted the pre-fix-837 branch February 3, 2022 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow serverForUri API to return password when connection is not to a named server
2 participants