Remove redundant S2 cells queries for operational intents #1042
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For what I believe are historical reasons (entity cells used to be in a separate table from the entities themselves rather than in a column of the entity), the S2 cells for an operational intent are currently retrieved separately and explicitly for each individual operational intent even though the cells had already been retrieved in the initial query for operational intent information. This resulted in an enormous number of additional queries -- one for each operational intent result -- which would cause, e.g., an operational intent search to perform 200+ SQL queries if the search returned 200 operational intents. All of these additional queries are unnecessary because each entity's S2 cells are already retrieved on the initial query.
This PR fixes that problem by simply deleting the redundant separate population of operational intent cells. Thanks to @BradNicolle for the catch and suggestion.