Apply rule against root-level strings #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 7ee3f3a The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ghost
commented
Jan 12, 2024
lib/rules/no-raw-text.ts
Outdated
| @@ -111,7 +111,7 @@ function checkSvelteLiteralOrText( | |||
| const loc = literal.loc! | |||
| context.report({ | |||
| loc, | |||
| message: `raw text '${literal.value}' is used` | |||
| message: `raw text '${literal.value.trimStart().trimEnd()}' is used` | |||
There was a problem hiding this comment.
I thought this would help with cleaning up the whitespace so the error message was relevant.
Co-authored-by: Yosuke Ota <otameshiyo23@gmail.com>
Co-authored-by: Yosuke Ota <otameshiyo23@gmail.com>
ghost
requested a review
from 
|
Thanks for being so quick with the review. When you get a chance can you publish a new version of the package to npm? Thanks again! |
This was referenced Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! Thanks for this handy lint rule. I noticed it wasn't working for raw strings at the root level. I made a chance and added a test. Hope this works, let me know if you'd like any changes.