Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix false positives in no-missing-keys #313

Merged
merged 1 commit into from
Apr 7, 2022
Merged

Fix false positives in no-missing-keys #313

merged 1 commit into from
Apr 7, 2022

Conversation

ota-meshi
Copy link
Member

fixes #311

@ota-meshi ota-meshi added the Type: Bug Bug or Bug fixes label Apr 6, 2022
@andruhon
Copy link

andruhon commented Apr 6, 2022

This seems to do the trick

@ota-meshi
Copy link
Member Author

What does trick mean? (I don't understand English so maybe I just don't understand what you're saying.)

@ota-meshi
Copy link
Member Author

@andruhon

@ota-meshi
Copy link
Member Author

I asked a friend what that meant. So no reply is needed 😅.

@ota-meshi ota-meshi merged commit 84d59fb into master Apr 7, 2022
@ota-meshi ota-meshi deleted the issue311 branch April 7, 2022 01:27
@andruhon
Copy link

andruhon commented Apr 7, 2022

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Type: Bug Bug or Bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

'no-missing-keys' doesn't respect fallback locale when accessing nested properties.
2 participants
@ota-meshi @andruhon