New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom corner radius support for CardPartBarView #259

Merged

croossin merged 1 commit into intuit:master from rattandeep1998:rds/barViewCornerRadius

Sep 28, 2020

Contributor

rattandeep1998 commented Sep 16, 2020

Before you make a Pull Request, read the important guidelines:

Issue Link 🔗

Feature Enhancement

Goals of this PR 🎉

Provide custom corner radius support for Card Part Bar View

How Has This Been Tested 🔍

Tested in Mint app

Test Configuration 👾

Xcode version: 11.6
Device/Simulator iPhone Xs
iOS version 13.6

Things to check on 🎯

My Pull Request code follows the coding standards and styles of the project
I have worked on unit tests and reviewed my code to the best of my ability
I have used comments to make other coders understand my code better
My changes are good to go without any warnings
All of my unit tests pass successfully before pushing the PR
I have made sure all dependent downstream changes impacted by my PR are working


          Custom border radius support for bar view

ed3e028

badrinathvm approved these changes

View reviewed changes

badrinathvm requested a review from croossin

September 28, 2020 18:42

croossin approved these changes

View reviewed changes

croossin merged commit 153012e into intuit:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet