Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next improvements #1135

Merged
merged 5 commits into from
Apr 7, 2020
Merged

Next improvements #1135

merged 5 commits into from
Apr 7, 2020

Conversation

hipstersmoothie
Copy link
Collaborator

@hipstersmoothie hipstersmoothie commented Apr 7, 2020

What Changed

  • dont omit unreleased commits in next branch
  • combine duplicate merge commits from gitlog -m
  • omit merge commits from next PR changelog

Why

Squash 🐛

Todo:

  • Add tests
  • Add docs
📦 Published PR as canary version: under canary scope @auto-canary@9.26.6-canary.1135.14740.0

✨ Test out this PR locally via:

npm install @auto-canary/bot-list@9.26.6-canary.1135.14740.0
npm install @auto-canary/auto@9.26.6-canary.1135.14740.0
npm install @auto-canary/core@9.26.6-canary.1135.14740.0
npm install @auto-canary/all-contributors@9.26.6-canary.1135.14740.0
npm install @auto-canary/brew@9.26.6-canary.1135.14740.0
npm install @auto-canary/chrome@9.26.6-canary.1135.14740.0
npm install @auto-canary/cocoapods@9.26.6-canary.1135.14740.0
npm install @auto-canary/conventional-commits@9.26.6-canary.1135.14740.0
npm install @auto-canary/crates@9.26.6-canary.1135.14740.0
npm install @auto-canary/exec@9.26.6-canary.1135.14740.0
npm install @auto-canary/first-time-contributor@9.26.6-canary.1135.14740.0
npm install @auto-canary/gh-pages@9.26.6-canary.1135.14740.0
npm install @auto-canary/git-tag@9.26.6-canary.1135.14740.0
npm install @auto-canary/gradle@9.26.6-canary.1135.14740.0
npm install @auto-canary/jira@9.26.6-canary.1135.14740.0
npm install @auto-canary/maven@9.26.6-canary.1135.14740.0
npm install @auto-canary/npm@9.26.6-canary.1135.14740.0
npm install @auto-canary/omit-commits@9.26.6-canary.1135.14740.0
npm install @auto-canary/omit-release-notes@9.26.6-canary.1135.14740.0
npm install @auto-canary/released@9.26.6-canary.1135.14740.0
npm install @auto-canary/s3@9.26.6-canary.1135.14740.0
npm install @auto-canary/slack@9.26.6-canary.1135.14740.0
npm install @auto-canary/twitter@9.26.6-canary.1135.14740.0
npm install @auto-canary/upload-assets@9.26.6-canary.1135.14740.0
# or 
yarn add @auto-canary/bot-list@9.26.6-canary.1135.14740.0
yarn add @auto-canary/auto@9.26.6-canary.1135.14740.0
yarn add @auto-canary/core@9.26.6-canary.1135.14740.0
yarn add @auto-canary/all-contributors@9.26.6-canary.1135.14740.0
yarn add @auto-canary/brew@9.26.6-canary.1135.14740.0
yarn add @auto-canary/chrome@9.26.6-canary.1135.14740.0
yarn add @auto-canary/cocoapods@9.26.6-canary.1135.14740.0
yarn add @auto-canary/conventional-commits@9.26.6-canary.1135.14740.0
yarn add @auto-canary/crates@9.26.6-canary.1135.14740.0
yarn add @auto-canary/exec@9.26.6-canary.1135.14740.0
yarn add @auto-canary/first-time-contributor@9.26.6-canary.1135.14740.0
yarn add @auto-canary/gh-pages@9.26.6-canary.1135.14740.0
yarn add @auto-canary/git-tag@9.26.6-canary.1135.14740.0
yarn add @auto-canary/gradle@9.26.6-canary.1135.14740.0
yarn add @auto-canary/jira@9.26.6-canary.1135.14740.0
yarn add @auto-canary/maven@9.26.6-canary.1135.14740.0
yarn add @auto-canary/npm@9.26.6-canary.1135.14740.0
yarn add @auto-canary/omit-commits@9.26.6-canary.1135.14740.0
yarn add @auto-canary/omit-release-notes@9.26.6-canary.1135.14740.0
yarn add @auto-canary/released@9.26.6-canary.1135.14740.0
yarn add @auto-canary/s3@9.26.6-canary.1135.14740.0
yarn add @auto-canary/slack@9.26.6-canary.1135.14740.0
yarn add @auto-canary/twitter@9.26.6-canary.1135.14740.0
yarn add @auto-canary/upload-assets@9.26.6-canary.1135.14740.0

@hipstersmoothie hipstersmoothie added the patch Increment the patch version when merged label Apr 7, 2020
@codecov
Copy link

codecov bot commented Apr 7, 2020

Codecov Report

Merging #1135 into master will increase coverage by 0.00%.
The diff coverage is 89.47%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1135   +/-   ##
=======================================
  Coverage   81.59%   81.59%           
=======================================
  Files          53       53           
  Lines        3765     3777   +12     
  Branches      800      760   -40     
=======================================
+ Hits         3072     3082   +10     
- Misses        505      507    +2     
  Partials      188      188           
Impacted Files Coverage Δ
packages/core/src/auto.ts 79.18% <50.00%> (-0.17%) ⬇️
packages/core/src/git.ts 88.02% <100.00%> (+0.18%) ⬆️
packages/core/src/release.ts 94.53% <100.00%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 249a2cb...97f3fd6. Read the comment docs.

@hipstersmoothie hipstersmoothie merged commit 13063c1 into master Apr 7, 2020
@hipstersmoothie hipstersmoothie deleted the next-improvements branch April 7, 2020 21:58
@adierkens
Copy link
Collaborator

🚀 PR was released in v9.26.6 🚀

@adierkens adierkens added the released This issue/pull request has been released. label Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants