Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow more rc file types #1235

Merged
merged 1 commit into from
May 19, 2020
Merged

allow more rc file types #1235

merged 1 commit into from
May 19, 2020

Conversation

hipstersmoothie
Copy link
Collaborator

@hipstersmoothie hipstersmoothie commented May 19, 2020

What Changed

Allow .autorc.js and auto.config.js again.

Why

closes #1234

Todo:

  • Add docs
📦 Published PR as canary version: under canary scope @auto-canary@9.33.3-canary.1235.15828.0

✨ Test out this PR locally via:

npm install @auto-canary/bot-list@9.33.3-canary.1235.15828.0
npm install @auto-canary/auto@9.33.3-canary.1235.15828.0
npm install @auto-canary/core@9.33.3-canary.1235.15828.0
npm install @auto-canary/all-contributors@9.33.3-canary.1235.15828.0
npm install @auto-canary/brew@9.33.3-canary.1235.15828.0
npm install @auto-canary/chrome@9.33.3-canary.1235.15828.0
npm install @auto-canary/cocoapods@9.33.3-canary.1235.15828.0
npm install @auto-canary/conventional-commits@9.33.3-canary.1235.15828.0
npm install @auto-canary/crates@9.33.3-canary.1235.15828.0
npm install @auto-canary/exec@9.33.3-canary.1235.15828.0
npm install @auto-canary/first-time-contributor@9.33.3-canary.1235.15828.0
npm install @auto-canary/gem@9.33.3-canary.1235.15828.0
npm install @auto-canary/gh-pages@9.33.3-canary.1235.15828.0
npm install @auto-canary/git-tag@9.33.3-canary.1235.15828.0
npm install @auto-canary/gradle@9.33.3-canary.1235.15828.0
npm install @auto-canary/jira@9.33.3-canary.1235.15828.0
npm install @auto-canary/maven@9.33.3-canary.1235.15828.0
npm install @auto-canary/npm@9.33.3-canary.1235.15828.0
npm install @auto-canary/omit-commits@9.33.3-canary.1235.15828.0
npm install @auto-canary/omit-release-notes@9.33.3-canary.1235.15828.0
npm install @auto-canary/released@9.33.3-canary.1235.15828.0
npm install @auto-canary/s3@9.33.3-canary.1235.15828.0
npm install @auto-canary/slack@9.33.3-canary.1235.15828.0
npm install @auto-canary/twitter@9.33.3-canary.1235.15828.0
npm install @auto-canary/upload-assets@9.33.3-canary.1235.15828.0
# or 
yarn add @auto-canary/bot-list@9.33.3-canary.1235.15828.0
yarn add @auto-canary/auto@9.33.3-canary.1235.15828.0
yarn add @auto-canary/core@9.33.3-canary.1235.15828.0
yarn add @auto-canary/all-contributors@9.33.3-canary.1235.15828.0
yarn add @auto-canary/brew@9.33.3-canary.1235.15828.0
yarn add @auto-canary/chrome@9.33.3-canary.1235.15828.0
yarn add @auto-canary/cocoapods@9.33.3-canary.1235.15828.0
yarn add @auto-canary/conventional-commits@9.33.3-canary.1235.15828.0
yarn add @auto-canary/crates@9.33.3-canary.1235.15828.0
yarn add @auto-canary/exec@9.33.3-canary.1235.15828.0
yarn add @auto-canary/first-time-contributor@9.33.3-canary.1235.15828.0
yarn add @auto-canary/gem@9.33.3-canary.1235.15828.0
yarn add @auto-canary/gh-pages@9.33.3-canary.1235.15828.0
yarn add @auto-canary/git-tag@9.33.3-canary.1235.15828.0
yarn add @auto-canary/gradle@9.33.3-canary.1235.15828.0
yarn add @auto-canary/jira@9.33.3-canary.1235.15828.0
yarn add @auto-canary/maven@9.33.3-canary.1235.15828.0
yarn add @auto-canary/npm@9.33.3-canary.1235.15828.0
yarn add @auto-canary/omit-commits@9.33.3-canary.1235.15828.0
yarn add @auto-canary/omit-release-notes@9.33.3-canary.1235.15828.0
yarn add @auto-canary/released@9.33.3-canary.1235.15828.0
yarn add @auto-canary/s3@9.33.3-canary.1235.15828.0
yarn add @auto-canary/slack@9.33.3-canary.1235.15828.0
yarn add @auto-canary/twitter@9.33.3-canary.1235.15828.0
yarn add @auto-canary/upload-assets@9.33.3-canary.1235.15828.0

@hipstersmoothie hipstersmoothie added the minor Increment the minor version when merged label May 19, 2020
@codecov
Copy link

codecov bot commented May 19, 2020

Codecov Report

Merging #1235 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1235   +/-   ##
=======================================
  Coverage   80.93%   80.93%           
=======================================
  Files          56       56           
  Lines        4044     4044           
  Branches      827      870   +43     
=======================================
  Hits         3273     3273           
  Misses        550      550           
  Partials      221      221           
Impacted Files Coverage Δ
packages/core/src/config.ts 89.53% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09c2099...af4f2e4. Read the comment docs.

@hipstersmoothie hipstersmoothie merged commit 26a90c2 into master May 19, 2020
@hipstersmoothie hipstersmoothie deleted the auto-rc-js branch May 19, 2020 16:47
@bmuenzenmeyer
Copy link
Contributor

wow - thank you so much for the fast turnaround!

@adierkens
Copy link
Collaborator

🚀 PR was released in v9.34.0 🚀

@adierkens adierkens added the released This issue/pull request has been released. label May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Increment the minor version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support .autorc.js config file
3 participants