Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix reduce without initial value #1249

Merged
merged 4 commits into from
May 23, 2020
Merged

fix reduce without initial value #1249

merged 4 commits into from
May 23, 2020

Conversation

hipstersmoothie
Copy link
Collaborator

@hipstersmoothie hipstersmoothie commented May 23, 2020

What Changed

One reduce didn't have an initial value, failing the release.

Why

https://circleci.com/gh/jpaulobneto/lerna-auto-publish/19?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link

@jpaulobneto this should fix your build on that repo

📦 Published PR as canary version: under canary scope @auto-canary@9.36.1-canary.1249.16001.0

✨ Test out this PR locally via:

npm install @auto-canary/bot-list@9.36.1-canary.1249.16001.0
npm install @auto-canary/auto@9.36.1-canary.1249.16001.0
npm install @auto-canary/core@9.36.1-canary.1249.16001.0
npm install @auto-canary/all-contributors@9.36.1-canary.1249.16001.0
npm install @auto-canary/brew@9.36.1-canary.1249.16001.0
npm install @auto-canary/chrome@9.36.1-canary.1249.16001.0
npm install @auto-canary/cocoapods@9.36.1-canary.1249.16001.0
npm install @auto-canary/conventional-commits@9.36.1-canary.1249.16001.0
npm install @auto-canary/crates@9.36.1-canary.1249.16001.0
npm install @auto-canary/exec@9.36.1-canary.1249.16001.0
npm install @auto-canary/first-time-contributor@9.36.1-canary.1249.16001.0
npm install @auto-canary/gem@9.36.1-canary.1249.16001.0
npm install @auto-canary/gh-pages@9.36.1-canary.1249.16001.0
npm install @auto-canary/git-tag@9.36.1-canary.1249.16001.0
npm install @auto-canary/gradle@9.36.1-canary.1249.16001.0
npm install @auto-canary/jira@9.36.1-canary.1249.16001.0
npm install @auto-canary/maven@9.36.1-canary.1249.16001.0
npm install @auto-canary/npm@9.36.1-canary.1249.16001.0
npm install @auto-canary/omit-commits@9.36.1-canary.1249.16001.0
npm install @auto-canary/omit-release-notes@9.36.1-canary.1249.16001.0
npm install @auto-canary/released@9.36.1-canary.1249.16001.0
npm install @auto-canary/s3@9.36.1-canary.1249.16001.0
npm install @auto-canary/slack@9.36.1-canary.1249.16001.0
npm install @auto-canary/twitter@9.36.1-canary.1249.16001.0
npm install @auto-canary/upload-assets@9.36.1-canary.1249.16001.0
# or 
yarn add @auto-canary/bot-list@9.36.1-canary.1249.16001.0
yarn add @auto-canary/auto@9.36.1-canary.1249.16001.0
yarn add @auto-canary/core@9.36.1-canary.1249.16001.0
yarn add @auto-canary/all-contributors@9.36.1-canary.1249.16001.0
yarn add @auto-canary/brew@9.36.1-canary.1249.16001.0
yarn add @auto-canary/chrome@9.36.1-canary.1249.16001.0
yarn add @auto-canary/cocoapods@9.36.1-canary.1249.16001.0
yarn add @auto-canary/conventional-commits@9.36.1-canary.1249.16001.0
yarn add @auto-canary/crates@9.36.1-canary.1249.16001.0
yarn add @auto-canary/exec@9.36.1-canary.1249.16001.0
yarn add @auto-canary/first-time-contributor@9.36.1-canary.1249.16001.0
yarn add @auto-canary/gem@9.36.1-canary.1249.16001.0
yarn add @auto-canary/gh-pages@9.36.1-canary.1249.16001.0
yarn add @auto-canary/git-tag@9.36.1-canary.1249.16001.0
yarn add @auto-canary/gradle@9.36.1-canary.1249.16001.0
yarn add @auto-canary/jira@9.36.1-canary.1249.16001.0
yarn add @auto-canary/maven@9.36.1-canary.1249.16001.0
yarn add @auto-canary/npm@9.36.1-canary.1249.16001.0
yarn add @auto-canary/omit-commits@9.36.1-canary.1249.16001.0
yarn add @auto-canary/omit-release-notes@9.36.1-canary.1249.16001.0
yarn add @auto-canary/released@9.36.1-canary.1249.16001.0
yarn add @auto-canary/s3@9.36.1-canary.1249.16001.0
yarn add @auto-canary/slack@9.36.1-canary.1249.16001.0
yarn add @auto-canary/twitter@9.36.1-canary.1249.16001.0
yarn add @auto-canary/upload-assets@9.36.1-canary.1249.16001.0

@hipstersmoothie hipstersmoothie added the patch Increment the patch version when merged label May 23, 2020
@codecov
Copy link

codecov bot commented May 23, 2020

Codecov Report

Merging #1249 into master will increase coverage by 0.02%.
The diff coverage is 83.87%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1249      +/-   ##
==========================================
+ Coverage   80.89%   80.91%   +0.02%     
==========================================
  Files          56       56              
  Lines        4061     4067       +6     
  Branches      875      877       +2     
==========================================
+ Hits         3285     3291       +6     
- Misses        552      553       +1     
+ Partials      224      223       -1     
Impacted Files Coverage Δ
packages/core/src/validate-config.ts 91.22% <66.66%> (+0.07%) ⬆️
plugins/npm/src/index.ts 74.30% <71.42%> (-0.32%) ⬇️
packages/core/src/changelog.ts 96.00% <100.00%> (+0.02%) ⬆️
packages/core/src/git.ts 88.65% <100.00%> (+0.63%) ⬆️
packages/core/src/release.ts 94.57% <100.00%> (ø)
plugins/all-contributors/src/index.ts 84.84% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 307ec8f...4cd69dc. Read the comment docs.

@hipstersmoothie hipstersmoothie merged commit 672874d into master May 23, 2020
@hipstersmoothie hipstersmoothie deleted the buggo branch May 23, 2020 05:47
@adierkens
Copy link
Collaborator

🚀 PR was released in v9.36.1 🚀

@adierkens adierkens added the released This issue/pull request has been released. label May 23, 2020
@jpaulobneto
Copy link

Thank you guys!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants