Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: accurately name variable within inOldVersionBranch() #1271

Merged
merged 1 commit into from
Jun 3, 2020

Conversation

bmuenzenmeyer
Copy link
Contributor

@bmuenzenmeyer bmuenzenmeyer commented Jun 2, 2020

What Changed

Scoped variable within inOldVersionBranch

Why

When reading this source code, it was confusing to see mention of prerelease - which is irrelevant.

📦 Published PR as canary version: under canary scope @auto-canary@9.38.1-canary.1271.16211.0

✨ Test out this PR locally via:

npm install @auto-canary/bot-list@9.38.1-canary.1271.16211.0
npm install @auto-canary/auto@9.38.1-canary.1271.16211.0
npm install @auto-canary/core@9.38.1-canary.1271.16211.0
npm install @auto-canary/all-contributors@9.38.1-canary.1271.16211.0
npm install @auto-canary/brew@9.38.1-canary.1271.16211.0
npm install @auto-canary/chrome@9.38.1-canary.1271.16211.0
npm install @auto-canary/cocoapods@9.38.1-canary.1271.16211.0
npm install @auto-canary/conventional-commits@9.38.1-canary.1271.16211.0
npm install @auto-canary/crates@9.38.1-canary.1271.16211.0
npm install @auto-canary/exec@9.38.1-canary.1271.16211.0
npm install @auto-canary/first-time-contributor@9.38.1-canary.1271.16211.0
npm install @auto-canary/gem@9.38.1-canary.1271.16211.0
npm install @auto-canary/gh-pages@9.38.1-canary.1271.16211.0
npm install @auto-canary/git-tag@9.38.1-canary.1271.16211.0
npm install @auto-canary/gradle@9.38.1-canary.1271.16211.0
npm install @auto-canary/jira@9.38.1-canary.1271.16211.0
npm install @auto-canary/maven@9.38.1-canary.1271.16211.0
npm install @auto-canary/npm@9.38.1-canary.1271.16211.0
npm install @auto-canary/omit-commits@9.38.1-canary.1271.16211.0
npm install @auto-canary/omit-release-notes@9.38.1-canary.1271.16211.0
npm install @auto-canary/released@9.38.1-canary.1271.16211.0
npm install @auto-canary/s3@9.38.1-canary.1271.16211.0
npm install @auto-canary/slack@9.38.1-canary.1271.16211.0
npm install @auto-canary/twitter@9.38.1-canary.1271.16211.0
npm install @auto-canary/upload-assets@9.38.1-canary.1271.16211.0
# or 
yarn add @auto-canary/bot-list@9.38.1-canary.1271.16211.0
yarn add @auto-canary/auto@9.38.1-canary.1271.16211.0
yarn add @auto-canary/core@9.38.1-canary.1271.16211.0
yarn add @auto-canary/all-contributors@9.38.1-canary.1271.16211.0
yarn add @auto-canary/brew@9.38.1-canary.1271.16211.0
yarn add @auto-canary/chrome@9.38.1-canary.1271.16211.0
yarn add @auto-canary/cocoapods@9.38.1-canary.1271.16211.0
yarn add @auto-canary/conventional-commits@9.38.1-canary.1271.16211.0
yarn add @auto-canary/crates@9.38.1-canary.1271.16211.0
yarn add @auto-canary/exec@9.38.1-canary.1271.16211.0
yarn add @auto-canary/first-time-contributor@9.38.1-canary.1271.16211.0
yarn add @auto-canary/gem@9.38.1-canary.1271.16211.0
yarn add @auto-canary/gh-pages@9.38.1-canary.1271.16211.0
yarn add @auto-canary/git-tag@9.38.1-canary.1271.16211.0
yarn add @auto-canary/gradle@9.38.1-canary.1271.16211.0
yarn add @auto-canary/jira@9.38.1-canary.1271.16211.0
yarn add @auto-canary/maven@9.38.1-canary.1271.16211.0
yarn add @auto-canary/npm@9.38.1-canary.1271.16211.0
yarn add @auto-canary/omit-commits@9.38.1-canary.1271.16211.0
yarn add @auto-canary/omit-release-notes@9.38.1-canary.1271.16211.0
yarn add @auto-canary/released@9.38.1-canary.1271.16211.0
yarn add @auto-canary/s3@9.38.1-canary.1271.16211.0
yarn add @auto-canary/slack@9.38.1-canary.1271.16211.0
yarn add @auto-canary/twitter@9.38.1-canary.1271.16211.0
yarn add @auto-canary/upload-assets@9.38.1-canary.1271.16211.0

@codecov
Copy link

codecov bot commented Jun 2, 2020

Codecov Report

Merging #1271 into master will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1271   +/-   ##
=======================================
  Coverage   81.01%   81.01%           
=======================================
  Files          56       56           
  Lines        4083     4083           
  Branches      883      840   -43     
=======================================
  Hits         3308     3308           
  Misses        552      552           
  Partials      223      223           
Impacted Files Coverage Δ
packages/core/src/auto.ts 76.88% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f37945b...866ee60. Read the comment docs.

@hipstersmoothie hipstersmoothie added the internal Changes only affect the internal API label Jun 3, 2020
@hipstersmoothie hipstersmoothie merged commit 47d3b54 into intuit:master Jun 3, 2020
@adierkens
Copy link
Collaborator

🚀 PR was released in v9.38.1 🚀

@adierkens adierkens added the released This issue/pull request has been released. label Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Changes only affect the internal API released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants