Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auto generate contributors if a contributors list exists but none are… #1575

Conversation

kendallgassner
Copy link
Contributor

@kendallgassner kendallgassner commented Oct 8, 2020

When i first add auto all contributors to a project I have to back track and add the all contributors list to my repo
that is fine but if a list exists in my rc can auto check if it is initialized in my readme and if it isnt can it add it?

📦 Published PR as canary version: under canary scope @auto-canary@9.56.1-canary.1575.19347.0

✨ Test out this PR locally via:

npm install @auto-canary/bot-list@9.56.1-canary.1575.19347.0
npm install @auto-canary/auto@9.56.1-canary.1575.19347.0
npm install @auto-canary/core@9.56.1-canary.1575.19347.0
npm install @auto-canary/all-contributors@9.56.1-canary.1575.19347.0
npm install @auto-canary/brew@9.56.1-canary.1575.19347.0
npm install @auto-canary/chrome@9.56.1-canary.1575.19347.0
npm install @auto-canary/cocoapods@9.56.1-canary.1575.19347.0
npm install @auto-canary/conventional-commits@9.56.1-canary.1575.19347.0
npm install @auto-canary/crates@9.56.1-canary.1575.19347.0
npm install @auto-canary/docker@9.56.1-canary.1575.19347.0
npm install @auto-canary/exec@9.56.1-canary.1575.19347.0
npm install @auto-canary/first-time-contributor@9.56.1-canary.1575.19347.0
npm install @auto-canary/gem@9.56.1-canary.1575.19347.0
npm install @auto-canary/gh-pages@9.56.1-canary.1575.19347.0
npm install @auto-canary/git-tag@9.56.1-canary.1575.19347.0
npm install @auto-canary/gradle@9.56.1-canary.1575.19347.0
npm install @auto-canary/jira@9.56.1-canary.1575.19347.0
npm install @auto-canary/maven@9.56.1-canary.1575.19347.0
npm install @auto-canary/npm@9.56.1-canary.1575.19347.0
npm install @auto-canary/omit-commits@9.56.1-canary.1575.19347.0
npm install @auto-canary/omit-release-notes@9.56.1-canary.1575.19347.0
npm install @auto-canary/pr-body-labels@9.56.1-canary.1575.19347.0
npm install @auto-canary/released@9.56.1-canary.1575.19347.0
npm install @auto-canary/s3@9.56.1-canary.1575.19347.0
npm install @auto-canary/slack@9.56.1-canary.1575.19347.0
npm install @auto-canary/twitter@9.56.1-canary.1575.19347.0
npm install @auto-canary/upload-assets@9.56.1-canary.1575.19347.0
# or 
yarn add @auto-canary/bot-list@9.56.1-canary.1575.19347.0
yarn add @auto-canary/auto@9.56.1-canary.1575.19347.0
yarn add @auto-canary/core@9.56.1-canary.1575.19347.0
yarn add @auto-canary/all-contributors@9.56.1-canary.1575.19347.0
yarn add @auto-canary/brew@9.56.1-canary.1575.19347.0
yarn add @auto-canary/chrome@9.56.1-canary.1575.19347.0
yarn add @auto-canary/cocoapods@9.56.1-canary.1575.19347.0
yarn add @auto-canary/conventional-commits@9.56.1-canary.1575.19347.0
yarn add @auto-canary/crates@9.56.1-canary.1575.19347.0
yarn add @auto-canary/docker@9.56.1-canary.1575.19347.0
yarn add @auto-canary/exec@9.56.1-canary.1575.19347.0
yarn add @auto-canary/first-time-contributor@9.56.1-canary.1575.19347.0
yarn add @auto-canary/gem@9.56.1-canary.1575.19347.0
yarn add @auto-canary/gh-pages@9.56.1-canary.1575.19347.0
yarn add @auto-canary/git-tag@9.56.1-canary.1575.19347.0
yarn add @auto-canary/gradle@9.56.1-canary.1575.19347.0
yarn add @auto-canary/jira@9.56.1-canary.1575.19347.0
yarn add @auto-canary/maven@9.56.1-canary.1575.19347.0
yarn add @auto-canary/npm@9.56.1-canary.1575.19347.0
yarn add @auto-canary/omit-commits@9.56.1-canary.1575.19347.0
yarn add @auto-canary/omit-release-notes@9.56.1-canary.1575.19347.0
yarn add @auto-canary/pr-body-labels@9.56.1-canary.1575.19347.0
yarn add @auto-canary/released@9.56.1-canary.1575.19347.0
yarn add @auto-canary/s3@9.56.1-canary.1575.19347.0
yarn add @auto-canary/slack@9.56.1-canary.1575.19347.0
yarn add @auto-canary/twitter@9.56.1-canary.1575.19347.0
yarn add @auto-canary/upload-assets@9.56.1-canary.1575.19347.0

@hipstersmoothie hipstersmoothie added the minor Increment the minor version when merged label Oct 8, 2020
@codecov
Copy link

codecov bot commented Oct 8, 2020

Codecov Report

Merging #1575 into master will increase coverage by 0.00%.
The diff coverage is 84.21%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1575   +/-   ##
=======================================
  Coverage   81.13%   81.13%           
=======================================
  Files          60       60           
  Lines        4420     4432   +12     
  Branches      988      992    +4     
=======================================
+ Hits         3586     3596   +10     
  Misses        577      577           
- Partials      257      259    +2     
Impacted Files Coverage Δ
plugins/all-contributors/src/index.ts 83.66% <84.21%> (-0.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09550b2...284c18a. Read the comment docs.

@hipstersmoothie hipstersmoothie merged commit 7e907c9 into intuit:master Oct 8, 2020
@adierkens
Copy link
Collaborator

🚀 PR was released in v9.57.0 🚀

@adierkens adierkens added the released This issue/pull request has been released. label Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest minor Increment the minor version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants