feat: run pod lib lint during dryrun #1576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Changed
Tap the
beforeShipIthook to runpod lib lintduring adryRunofshipit.Why
During an actual
shipitcall,pod repo pushis executed to push the updated podspec file to the specs repository. Internally,pod repo pushwill callpod lib lintto ensure the podspec file validates before pushing it.During a dryrun, we will now run
pod lib lintto simulate part ofpod repo pushwhile giving feedback to the user if shipit could have succeeded.Todo:
Change Type
Indicate the type of change your pull request is:
documentationpatchminormajor📦 Published PR as canary version:
under canary scope @auto-canary@9.55.1-canary.1576.19315.0✨ Test out this PR locally via:
npm install @auto-canary/bot-list@9.55.1-canary.1576.19315.0 npm install @auto-canary/auto@9.55.1-canary.1576.19315.0 npm install @auto-canary/core@9.55.1-canary.1576.19315.0 npm install @auto-canary/all-contributors@9.55.1-canary.1576.19315.0 npm install @auto-canary/brew@9.55.1-canary.1576.19315.0 npm install @auto-canary/chrome@9.55.1-canary.1576.19315.0 npm install @auto-canary/cocoapods@9.55.1-canary.1576.19315.0 npm install @auto-canary/conventional-commits@9.55.1-canary.1576.19315.0 npm install @auto-canary/crates@9.55.1-canary.1576.19315.0 npm install @auto-canary/docker@9.55.1-canary.1576.19315.0 npm install @auto-canary/exec@9.55.1-canary.1576.19315.0 npm install @auto-canary/first-time-contributor@9.55.1-canary.1576.19315.0 npm install @auto-canary/gem@9.55.1-canary.1576.19315.0 npm install @auto-canary/gh-pages@9.55.1-canary.1576.19315.0 npm install @auto-canary/git-tag@9.55.1-canary.1576.19315.0 npm install @auto-canary/gradle@9.55.1-canary.1576.19315.0 npm install @auto-canary/jira@9.55.1-canary.1576.19315.0 npm install @auto-canary/maven@9.55.1-canary.1576.19315.0 npm install @auto-canary/npm@9.55.1-canary.1576.19315.0 npm install @auto-canary/omit-commits@9.55.1-canary.1576.19315.0 npm install @auto-canary/omit-release-notes@9.55.1-canary.1576.19315.0 npm install @auto-canary/pr-body-labels@9.55.1-canary.1576.19315.0 npm install @auto-canary/released@9.55.1-canary.1576.19315.0 npm install @auto-canary/s3@9.55.1-canary.1576.19315.0 npm install @auto-canary/slack@9.55.1-canary.1576.19315.0 npm install @auto-canary/twitter@9.55.1-canary.1576.19315.0 npm install @auto-canary/upload-assets@9.55.1-canary.1576.19315.0 # or yarn add @auto-canary/bot-list@9.55.1-canary.1576.19315.0 yarn add @auto-canary/auto@9.55.1-canary.1576.19315.0 yarn add @auto-canary/core@9.55.1-canary.1576.19315.0 yarn add @auto-canary/all-contributors@9.55.1-canary.1576.19315.0 yarn add @auto-canary/brew@9.55.1-canary.1576.19315.0 yarn add @auto-canary/chrome@9.55.1-canary.1576.19315.0 yarn add @auto-canary/cocoapods@9.55.1-canary.1576.19315.0 yarn add @auto-canary/conventional-commits@9.55.1-canary.1576.19315.0 yarn add @auto-canary/crates@9.55.1-canary.1576.19315.0 yarn add @auto-canary/docker@9.55.1-canary.1576.19315.0 yarn add @auto-canary/exec@9.55.1-canary.1576.19315.0 yarn add @auto-canary/first-time-contributor@9.55.1-canary.1576.19315.0 yarn add @auto-canary/gem@9.55.1-canary.1576.19315.0 yarn add @auto-canary/gh-pages@9.55.1-canary.1576.19315.0 yarn add @auto-canary/git-tag@9.55.1-canary.1576.19315.0 yarn add @auto-canary/gradle@9.55.1-canary.1576.19315.0 yarn add @auto-canary/jira@9.55.1-canary.1576.19315.0 yarn add @auto-canary/maven@9.55.1-canary.1576.19315.0 yarn add @auto-canary/npm@9.55.1-canary.1576.19315.0 yarn add @auto-canary/omit-commits@9.55.1-canary.1576.19315.0 yarn add @auto-canary/omit-release-notes@9.55.1-canary.1576.19315.0 yarn add @auto-canary/pr-body-labels@9.55.1-canary.1576.19315.0 yarn add @auto-canary/released@9.55.1-canary.1576.19315.0 yarn add @auto-canary/s3@9.55.1-canary.1576.19315.0 yarn add @auto-canary/slack@9.55.1-canary.1576.19315.0 yarn add @auto-canary/twitter@9.55.1-canary.1576.19315.0 yarn add @auto-canary/upload-assets@9.55.1-canary.1576.19315.0