Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding cocoapod verbose logging #1580

Merged
merged 2 commits into from
Oct 13, 2020

Conversation

dcortright
Copy link

@dcortright dcortright commented Oct 12, 2020

What Changed

Updated CocoaPod plugin to check logging level of Auto and perform the appropriate logging based off of that.

Why

To give greater control to those using the CocoaPod plugin. Solves #1553

Todo:

  • Add tests
  • Add docs

Change Type

Indicate the type of change your pull request is:

  • documentation
  • patch
  • minor
  • major
📦 Published PR as canary version: under canary scope @auto-canary@9.57.1-canary.1580.19378.0

✨ Test out this PR locally via:

npm install @auto-canary/bot-list@9.57.1-canary.1580.19378.0
npm install @auto-canary/auto@9.57.1-canary.1580.19378.0
npm install @auto-canary/core@9.57.1-canary.1580.19378.0
npm install @auto-canary/all-contributors@9.57.1-canary.1580.19378.0
npm install @auto-canary/brew@9.57.1-canary.1580.19378.0
npm install @auto-canary/chrome@9.57.1-canary.1580.19378.0
npm install @auto-canary/cocoapods@9.57.1-canary.1580.19378.0
npm install @auto-canary/conventional-commits@9.57.1-canary.1580.19378.0
npm install @auto-canary/crates@9.57.1-canary.1580.19378.0
npm install @auto-canary/docker@9.57.1-canary.1580.19378.0
npm install @auto-canary/exec@9.57.1-canary.1580.19378.0
npm install @auto-canary/first-time-contributor@9.57.1-canary.1580.19378.0
npm install @auto-canary/gem@9.57.1-canary.1580.19378.0
npm install @auto-canary/gh-pages@9.57.1-canary.1580.19378.0
npm install @auto-canary/git-tag@9.57.1-canary.1580.19378.0
npm install @auto-canary/gradle@9.57.1-canary.1580.19378.0
npm install @auto-canary/jira@9.57.1-canary.1580.19378.0
npm install @auto-canary/maven@9.57.1-canary.1580.19378.0
npm install @auto-canary/npm@9.57.1-canary.1580.19378.0
npm install @auto-canary/omit-commits@9.57.1-canary.1580.19378.0
npm install @auto-canary/omit-release-notes@9.57.1-canary.1580.19378.0
npm install @auto-canary/pr-body-labels@9.57.1-canary.1580.19378.0
npm install @auto-canary/released@9.57.1-canary.1580.19378.0
npm install @auto-canary/s3@9.57.1-canary.1580.19378.0
npm install @auto-canary/slack@9.57.1-canary.1580.19378.0
npm install @auto-canary/twitter@9.57.1-canary.1580.19378.0
npm install @auto-canary/upload-assets@9.57.1-canary.1580.19378.0
# or 
yarn add @auto-canary/bot-list@9.57.1-canary.1580.19378.0
yarn add @auto-canary/auto@9.57.1-canary.1580.19378.0
yarn add @auto-canary/core@9.57.1-canary.1580.19378.0
yarn add @auto-canary/all-contributors@9.57.1-canary.1580.19378.0
yarn add @auto-canary/brew@9.57.1-canary.1580.19378.0
yarn add @auto-canary/chrome@9.57.1-canary.1580.19378.0
yarn add @auto-canary/cocoapods@9.57.1-canary.1580.19378.0
yarn add @auto-canary/conventional-commits@9.57.1-canary.1580.19378.0
yarn add @auto-canary/crates@9.57.1-canary.1580.19378.0
yarn add @auto-canary/docker@9.57.1-canary.1580.19378.0
yarn add @auto-canary/exec@9.57.1-canary.1580.19378.0
yarn add @auto-canary/first-time-contributor@9.57.1-canary.1580.19378.0
yarn add @auto-canary/gem@9.57.1-canary.1580.19378.0
yarn add @auto-canary/gh-pages@9.57.1-canary.1580.19378.0
yarn add @auto-canary/git-tag@9.57.1-canary.1580.19378.0
yarn add @auto-canary/gradle@9.57.1-canary.1580.19378.0
yarn add @auto-canary/jira@9.57.1-canary.1580.19378.0
yarn add @auto-canary/maven@9.57.1-canary.1580.19378.0
yarn add @auto-canary/npm@9.57.1-canary.1580.19378.0
yarn add @auto-canary/omit-commits@9.57.1-canary.1580.19378.0
yarn add @auto-canary/omit-release-notes@9.57.1-canary.1580.19378.0
yarn add @auto-canary/pr-body-labels@9.57.1-canary.1580.19378.0
yarn add @auto-canary/released@9.57.1-canary.1580.19378.0
yarn add @auto-canary/s3@9.57.1-canary.1580.19378.0
yarn add @auto-canary/slack@9.57.1-canary.1580.19378.0
yarn add @auto-canary/twitter@9.57.1-canary.1580.19378.0
yarn add @auto-canary/upload-assets@9.57.1-canary.1580.19378.0

@dcortright
Copy link
Author

dcortright commented Oct 12, 2020

And if everything is all good, could I get "hacktoberfest-accepted" added as a label as well?

@hipstersmoothie hipstersmoothie added minor Increment the minor version when merged hacktoberfest-accepted labels Oct 13, 2020
@hipstersmoothie hipstersmoothie merged commit cc1d17b into intuit:master Oct 13, 2020
@adierkens
Copy link
Collaborator

🚀 PR was released in v9.58.0 🚀

@adierkens adierkens added the released This issue/pull request has been released. label Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted minor Increment the minor version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants