Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve readability of release notes #1662

Merged
merged 1 commit into from
Nov 23, 2020

Conversation

hipstersmoothie
Copy link
Collaborator

@hipstersmoothie hipstersmoothie commented Nov 23, 2020

What Changed

Expand release notes titles for increased readability

Why

The old format required the user to cross reference the changelog to see what the changes were about

Todo:

  • Add tests
  • Add docs

Change Type

Indicate the type of change your pull request is:

  • documentation
  • patch
  • minor
  • major
📦 Published PR as canary version: under canary scope @auto-canary@10.4.1-canary.1662.20427.0

✨ Test out this PR locally via:

npm install @auto-canary/bot-list@10.4.1-canary.1662.20427.0
npm install @auto-canary/auto@10.4.1-canary.1662.20427.0
npm install @auto-canary/core@10.4.1-canary.1662.20427.0
npm install @auto-canary/all-contributors@10.4.1-canary.1662.20427.0
npm install @auto-canary/brew@10.4.1-canary.1662.20427.0
npm install @auto-canary/chrome@10.4.1-canary.1662.20427.0
npm install @auto-canary/cocoapods@10.4.1-canary.1662.20427.0
npm install @auto-canary/conventional-commits@10.4.1-canary.1662.20427.0
npm install @auto-canary/crates@10.4.1-canary.1662.20427.0
npm install @auto-canary/docker@10.4.1-canary.1662.20427.0
npm install @auto-canary/exec@10.4.1-canary.1662.20427.0
npm install @auto-canary/first-time-contributor@10.4.1-canary.1662.20427.0
npm install @auto-canary/gem@10.4.1-canary.1662.20427.0
npm install @auto-canary/gh-pages@10.4.1-canary.1662.20427.0
npm install @auto-canary/git-tag@10.4.1-canary.1662.20427.0
npm install @auto-canary/gradle@10.4.1-canary.1662.20427.0
npm install @auto-canary/jira@10.4.1-canary.1662.20427.0
npm install @auto-canary/maven@10.4.1-canary.1662.20427.0
npm install @auto-canary/microsoft-teams@10.4.1-canary.1662.20427.0
npm install @auto-canary/npm@10.4.1-canary.1662.20427.0
npm install @auto-canary/omit-commits@10.4.1-canary.1662.20427.0
npm install @auto-canary/omit-release-notes@10.4.1-canary.1662.20427.0
npm install @auto-canary/pr-body-labels@10.4.1-canary.1662.20427.0
npm install @auto-canary/released@10.4.1-canary.1662.20427.0
npm install @auto-canary/s3@10.4.1-canary.1662.20427.0
npm install @auto-canary/slack@10.4.1-canary.1662.20427.0
npm install @auto-canary/twitter@10.4.1-canary.1662.20427.0
npm install @auto-canary/upload-assets@10.4.1-canary.1662.20427.0
# or 
yarn add @auto-canary/bot-list@10.4.1-canary.1662.20427.0
yarn add @auto-canary/auto@10.4.1-canary.1662.20427.0
yarn add @auto-canary/core@10.4.1-canary.1662.20427.0
yarn add @auto-canary/all-contributors@10.4.1-canary.1662.20427.0
yarn add @auto-canary/brew@10.4.1-canary.1662.20427.0
yarn add @auto-canary/chrome@10.4.1-canary.1662.20427.0
yarn add @auto-canary/cocoapods@10.4.1-canary.1662.20427.0
yarn add @auto-canary/conventional-commits@10.4.1-canary.1662.20427.0
yarn add @auto-canary/crates@10.4.1-canary.1662.20427.0
yarn add @auto-canary/docker@10.4.1-canary.1662.20427.0
yarn add @auto-canary/exec@10.4.1-canary.1662.20427.0
yarn add @auto-canary/first-time-contributor@10.4.1-canary.1662.20427.0
yarn add @auto-canary/gem@10.4.1-canary.1662.20427.0
yarn add @auto-canary/gh-pages@10.4.1-canary.1662.20427.0
yarn add @auto-canary/git-tag@10.4.1-canary.1662.20427.0
yarn add @auto-canary/gradle@10.4.1-canary.1662.20427.0
yarn add @auto-canary/jira@10.4.1-canary.1662.20427.0
yarn add @auto-canary/maven@10.4.1-canary.1662.20427.0
yarn add @auto-canary/microsoft-teams@10.4.1-canary.1662.20427.0
yarn add @auto-canary/npm@10.4.1-canary.1662.20427.0
yarn add @auto-canary/omit-commits@10.4.1-canary.1662.20427.0
yarn add @auto-canary/omit-release-notes@10.4.1-canary.1662.20427.0
yarn add @auto-canary/pr-body-labels@10.4.1-canary.1662.20427.0
yarn add @auto-canary/released@10.4.1-canary.1662.20427.0
yarn add @auto-canary/s3@10.4.1-canary.1662.20427.0
yarn add @auto-canary/slack@10.4.1-canary.1662.20427.0
yarn add @auto-canary/twitter@10.4.1-canary.1662.20427.0
yarn add @auto-canary/upload-assets@10.4.1-canary.1662.20427.0

@hipstersmoothie hipstersmoothie force-pushed the release-notes-readability branch from f32064c to 9275aa1 Compare November 23, 2020 18:27
@hipstersmoothie hipstersmoothie changed the title Improve readability of releasee notes Improve readability of release notes Nov 23, 2020
@adierkens adierkens added the patch Increment the patch version when merged label Nov 23, 2020
@codecov
Copy link

codecov bot commented Nov 23, 2020

Codecov Report

Merging #1662 (9275aa1) into master (fd96fc7) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1662   +/-   ##
=======================================
  Coverage   80.24%   80.24%           
=======================================
  Files          61       61           
  Lines        4666     4668    +2     
  Branches     1064     1065    +1     
=======================================
+ Hits         3744     3746    +2     
  Misses        633      633           
  Partials      289      289           
Impacted Files Coverage Δ
packages/core/src/changelog.ts 95.58% <100.00%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99baf46...9275aa1. Read the comment docs.

@hipstersmoothie hipstersmoothie merged commit 0aebacc into master Nov 23, 2020
@hipstersmoothie hipstersmoothie deleted the release-notes-readability branch November 23, 2020 18:41
@adierkens
Copy link
Collaborator

🚀 PR was released in v10.4.1 🚀

@adierkens adierkens added the released This issue/pull request has been released. label Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants