Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(git): #2049 removes the use of deprecated error.headers #2202

Merged

Conversation

poloagustin
Copy link
Contributor

@poloagustin poloagustin commented May 11, 2022

What Changed

This PR removes the reference to error.headers that throws an error because it's deprecated on octokit

Why

Fixes #2049. This issues, supposedly, was fixed in #2064 but there are reports of it still happening

Todo:

  • Add tests
  • Add docs

Change Type

Indicate the type of change your pull request is:

  • documentation
  • patch
  • minor
  • major

Copy link
Contributor Author

@poloagustin poloagustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated PR description

@poloagustin
Copy link
Contributor Author

Not sure how to fix the pr-check action. I can't edit the PR labels with my permissions

@hipstersmoothie hipstersmoothie merged commit e7cacc7 into intuit:main May 20, 2022
@intuit-svc
Copy link

🚀 PR was released in v10.36.6 🚀

@intuit-svc intuit-svc added the released This issue/pull request has been released. label May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecation: [@octokit/request-error] error.headers is deprecated, use error.response.headers.
3 participants