Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing git 2.43.0 max number issue #2425 #2426

Merged
merged 2 commits into from
Feb 22, 2024
Merged

Conversation

Zweer
Copy link
Contributor

@Zweer Zweer commented Feb 21, 2024

What Changed

Fixing issue #2425

Why

Todo:

  • Add tests
  • Add docs

Change Type

Indicate the type of change your pull request is:

  • documentation
  • patch
  • minor
  • major

@hipstersmoothie hipstersmoothie added the patch Increment the patch version when merged label Feb 21, 2024
@hipstersmoothie
Copy link
Collaborator

@Zweer could you check that failing test? might just need to extend the timeout

Copy link

codecov bot commented Feb 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7a6f0ae) 85.92% compared to head (2a41d8d) 80.58%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2426      +/-   ##
==========================================
- Coverage   85.92%   80.58%   -5.34%     
==========================================
  Files          69       69              
  Lines        5675     5676       +1     
  Branches     1332     1274      -58     
==========================================
- Hits         4876     4574     -302     
- Misses        718      719       +1     
- Partials       81      383     +302     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hipstersmoothie hipstersmoothie merged commit 432e152 into intuit:main Feb 22, 2024
6 of 9 checks passed
@ethriel3695
Copy link

Copy link

🚀 PR was released in v11.0.5 🚀

@github-actions github-actions bot added the released This issue/pull request has been released. label Feb 22, 2024
@hipstersmoothie
Copy link
Collaborator

Sorry bout that. deleted all my keys recently

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants