Use AllowUserOptions in AutocompleteSelect instead of the custom addOption() function #1045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nas-tabchiche
requested changes
Nov 14, 2024
There was a problem hiding this comment.
On the right track. What remains to do before we merge it is to remove the createFromSelection prop and just pass allowUserOptions as a prop to the AutocompleteSelect component and forward it to MultiSelect.
This would simplify the component as it would remove a redundant if statement.
|
on the commit message : useless code not useful x) |
nas-tabchiche
deleted the
CA-612-use-allow-user-options-in-autocomplete-select-instead-of-the-custom-add-option-function
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring by using allowuseroptions and not the custom addOption function