This repository has been archived by the owner on Dec 8, 2020. It is now read-only.
More updates for Julia 1.0 #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was upper bounded at 0.4.0 for Julia 0.6 support.
The package no longer supports Julia 0.6 or earlier.
This is consistent with how one otherwise uses diagm.
omus
approved these changes
Oct 31, 2018
|
Looking at it more closely, I'm not actually sure that hooking this up into the modern broadcast machinery is all that worthwhile; overloading So I'm inclined to say we should merge this into our master so that it can go into the upstream review. |
Where is broadcast overridden? I can't seem to find it |
|
One example is at the end of |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
srandis nowRandom.seed!Pairinterface when extendingdiagmkronnow lives in LinearAlgebra, not Base