Skip to content
This repository has been archived by the owner on Dec 8, 2020. It is now read-only.

Updates based on upstream PR review #4

Merged
merged 2 commits into from
Nov 1, 2018
Merged

Updates based on upstream PR review #4

merged 2 commits into from
Nov 1, 2018

Conversation

ararslan
Copy link

@ararslan ararslan commented Nov 1, 2018

This is in keeping with general JuliaOpt practices.
It was changed amongst the other 1.0 compatibility changes but does not
seem to be necessary.
@iamed2
Copy link
Member

iamed2 commented Nov 1, 2018

Out of curiosity, is mutability of these expressions actually used anywhere?

@ararslan
Copy link
Author

ararslan commented Nov 1, 2018

Out of curiosity, is mutability of these expressions actually used anywhere?

I don't think so, at least it doesn't seem like it. ¯\_(ツ)_/¯

@ararslan ararslan merged commit f111790 into master Nov 1, 2018
@ararslan ararslan deleted the aa/pr-review branch November 1, 2018 18:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants