Apply suggestions from code review

Co-authored-by: Curtis Vogt <curtis.vogt@gmail.com>
invenia · Feb 19, 2022 · 6452e0b · 6452e0b
1 parent ee77d7a
commit 6452e0b
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/src/deprecated.jl b/src/deprecated.jl
@@ -6,10 +6,10 @@ import Dates: Date, DateTime
 export Inclusivity, inclusivity
 include("inclusivity.jl")
 
-@deprecate Date(interval::Interval{Date}) convert(Date, interval)
-@deprecate DateTime(interval::Interval{DateTime}) convert(DateTime, interval)
-@deprecate Date(interval::AnchoredInterval{P, Date} where P) convert(Date, interval)
-@deprecate DateTime(interval::AnchoredInterval{P, DateTime} where P) convert(DateTime, interval)
+@deprecate Date(interval::Interval{Date}) only(interval)
+@deprecate DateTime(interval::Interval{DateTime}) only(interval)
+@deprecate Date(interval::AnchoredInterval{P, Date} where P) only(interval)
+@deprecate DateTime(interval::AnchoredInterval{P, DateTime} where P) only(interval)
 
 
 function Endpoint{T,D}(ep::T, included::Bool) where {T,D}

diff --git a/src/interval.jl b/src/interval.jl
@@ -237,9 +237,9 @@ end
     only(interval::AbstractInterval)
 
 Returns the only element of a closed interval with coinciding endpoints (throws a
-DomainError otherwise).
+`DomainError` otherwise).
 """
-function Base.only(interval::Interval)
+function Base.only(interval::AbstractInterval)
     if first(interval) == last(interval) && isclosed(interval)
         return first(interval)
     else

diff --git a/test/interval.jl b/test/interval.jl
@@ -97,7 +97,7 @@
         @test hash(a) == hash(b)
     end
 
-    @testset "conversion" begin
+    @testset "only" begin
         @test_throws DomainError only(Interval{Open, Open}(10, 10))
         @test_throws DomainError only(Interval{Open, Closed}(10, 10))
         @test_throws DomainError only(Interval{Closed, Open}(10, 10))