Refactor generic isfinite support
#142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #142 +/- ##
==========================================
+ Coverage 74.39% 76.95% +2.55%
==========================================
Files 10 11 +1
Lines 457 512 +55
==========================================
+ Hits 340 394 +54
- Misses 117 118 +1
Continue to review full report at Codecov.
|
mattBrzezinski
approved these changes
Sep 15, 2020
| @@ -24,6 +24,7 @@ Base.eltype(::AbstractInterval{T}) where {T} = T | |||
| Base.broadcastable(x::AbstractInterval) = Ref(x) | |||
| bounds_types(x::AbstractInterval{T,L,R}) where {T,L,R} = (L, R) | |||
|
|
|||
| include("isfinite.jl") | |||
There was a problem hiding this comment.
Would this be worthwhile to maybe export?
There was a problem hiding this comment.
I definitely don't want to export this as it'll cause conflicts with Base.isfinite
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As
isfinite(::Char)is something that isn't desired to be supported in Base I'll refactor the Intervals.jl code to make internal support for this more reasonable.