-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docker: new debian:slim version #25
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far :) What do you think about leaving it open until running Invenio with the cookiecutter-invenio-instance modifications is stable?
python3.6-slim/Dockerfile
Outdated
&& rm -rf /var/lib/apt/lists/* /tmp/* /var/tmp/* \ | ||
&& rm -rf ${WORKING_DIR}/.cache | ||
|
||
SHELL ["/bin/bash", "-c"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is explicitly needed because of CentOS (see more here basically, what was happening is that if we wouldn't change the shell, when we would execute a command inside the produced container there wouldn't be Python3 available). I think it is not needed here, can you try without it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I comment it. You're right, no problem occurs after that.
' \ | ||
&& apt-get update \ | ||
&& apt-get install --no-install-recommends -y \ | ||
git \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are missing python-cairosvg
which is required by Invenio-Formatter to generate badges (it is part of the Invenio base bundle).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I add it in "persistent" dependencies.
Closing PR because it's been stale for a long time. |
I create a slim version (Debian based image) to reduce size of an Invenio instance.
Note: I put here the way I test cookiecutter with this Docker (Cf. https://hackmd.io/-L-1CJwZQsGdfnM9XsRTpg?view)