Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker: new debian:slim version #25

Closed
wants to merge 1 commit into from

Conversation

blankoworld
Copy link

@blankoworld blankoworld commented Sep 2, 2019

I create a slim version (Debian based image) to reduce size of an Invenio instance.

Note: I put here the way I test cookiecutter with this Docker (Cf. https://hackmd.io/-L-1CJwZQsGdfnM9XsRTpg?view)

Copy link
Member

@diegodelemos diegodelemos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far :) What do you think about leaving it open until running Invenio with the cookiecutter-invenio-instance modifications is stable?

&& rm -rf /var/lib/apt/lists/* /tmp/* /var/tmp/* \
&& rm -rf ${WORKING_DIR}/.cache

SHELL ["/bin/bash", "-c"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is explicitly needed because of CentOS (see more here basically, what was happening is that if we wouldn't change the shell, when we would execute a command inside the produced container there wouldn't be Python3 available). I think it is not needed here, can you try without it?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I comment it. You're right, no problem occurs after that.

' \
&& apt-get update \
&& apt-get install --no-install-recommends -y \
git \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are missing python-cairosvg which is required by Invenio-Formatter to generate badges (it is part of the Invenio base bundle).

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I add it in "persistent" dependencies.

@lnielsen
Copy link
Member

Closing PR because it's been stale for a long time.

@lnielsen lnielsen closed this Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants