self-checkout: use dedicated endpoints #1223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntarocco
force-pushed
the
fix/self-checkout-new-endpoint
branch
4 times, most recently
from
0634af9 to
44c640f
Compare
ntarocco
commented
Oct 28, 2024
| @@ -0,0 +1,19 @@ | |||
| {% block title %} | |||
There was a problem hiding this comment.
To be added to CDS-ILS too
ntarocco
force-pushed
the
fix/self-checkout-new-endpoint
branch
from
44c640f to
4b1ba48
Compare
ntarocco
force-pushed
the
fix/self-checkout-new-endpoint
branch
from
4b1ba48 to
0a6c421
Compare
ntarocco
commented
Oct 29, 2024
| @@ -162,7 +162,13 @@ | |||
| dest="ITEM_ON_LOAN", | |||
| trigger="checkout", | |||
| transition=ILSToItemOnLoan, | |||
| permission_factory=loan_checkout_permission, | |||
| permission_factory=backoffice_permission, | |||
There was a problem hiding this comment.
kpsherva
reviewed
Oct 29, 2024
| class LoanSelfCheckoutDocumentOverbooked(LoanSelfCheckoutItemUnavailable): | ||
| """A patron cannot self-checkout an item for an overbooked document.""" | ||
|
|
||
| supportCode = "SELF-CHECKOUT-002" |
There was a problem hiding this comment.
I think we should share these codes with the librarians, since they will be the first point of contact
There was a problem hiding this comment.
Yes, that was the idea indeed ;)
kpsherva
approved these changes
Oct 29, 2024
ntarocco
force-pushed
the
fix/self-checkout-new-endpoint
branch
2 times, most recently
from
16fdd3e to
c5aa57d
Compare
ntarocco
force-pushed
the
fix/self-checkout-new-endpoint
branch
from
c5aa57d to
b7018c3
Compare
anikachurilova
force-pushed
the
fix/self-checkout-new-endpoint
branch
2 times, most recently
from
62575d0 to
9897ceb
Compare
ntarocco
commented
Nov 8, 2024
|
|
||
| try: | ||
| pid, item = self_checkout_get_item_by_barcode(barcode) | ||
| except ItemCannotCirculateError: |
There was a problem hiding this comment.
The msg Item not found is not very clear, as the user does not know what is an Item.
We should catch ItemNotFound here, and re-raise an exception with a different exc LoanSelfCheckoutItemNotFound, e.g. Literature not found. Please try again with another barcode or contact the library.
There was a problem hiding this comment.
Done ✅ and updated screeshots here: inveniosoftware/react-invenio-app-ils#649
* define new ad-hoc search and checkout endpoints, to be able to have better control on contraints and input and output payloads * use delivery methods to store when the checkout is a self-checkout * closes CERNDocumentServer/cds-ils#927
anikachurilova
force-pushed
the
fix/self-checkout-new-endpoint
branch
from
9897ceb to
840a2e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
better control on contraints and input and output payloads