Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config: added links for thumbnails #1799

Merged
merged 3 commits into from
Aug 28, 2024
Merged

config: added links for thumbnails #1799

merged 3 commits into from
Aug 28, 2024

Conversation

0einstein0
Copy link
Member

@0einstein0 0einstein0 commented Aug 21, 2024 •
edited
Loading

❤️ Thank you for your contribution!

Description

Added links for thumbnails in RDMRecordServiceConfig

/api/records/228

"thumbnails": {
    "10": "https://127.0.0.1:5000/api/iiif/record:228:Screenshot 2024-08-15 at 17.24.39.png/full/^10,/0/default.png",
    "50": "https://127.0.0.1:5000/api/iiif/record:228:Screenshot 2024-08-15 at 17.24.39.png/full/^50,/0/default.png",
    "100": "https://127.0.0.1:5000/api/iiif/record:228:Screenshot 2024-08-15 at 17.24.39.png/full/^100,/0/default.png",
    "250": "https://127.0.0.1:5000/api/iiif/record:228:Screenshot 2024-08-15 at 17.24.39.png/full/^250,/0/default.png",
    "750": "https://127.0.0.1:5000/api/iiif/record:228:Screenshot 2024-08-15 at 17.24.39.png/full/^750,/0/default.png",
    "1200": "https://127.0.0.1:5000/api/iiif/record:228:Screenshot 2024-08-15 at 17.24.39.png/full/^1200,/0/default.png"
},

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

Frontend

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

  1. You license your contribution under the same terms as the current repository’s license.
  2. You agree that you have the right to license your contribution under the current repository’s license.

@0einstein0 0einstein0 closed this Aug 21, 2024
@0einstein0 0einstein0 reopened this Aug 21, 2024
slint
slint reviewed Aug 23, 2024
View reviewed changes
Copy link
Member

@slint slint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some restructuring and renames, but otherwise looking good

invenio_rdm_records/services/config.py Outdated Show resolved Hide resolved
invenio_rdm_records/services/config.py Outdated Show resolved Hide resolved
invenio_rdm_records/services/config.py Outdated Show resolved Hide resolved
invenio_rdm_records/services/config.py Outdated Show resolved Hide resolved
invenio_rdm_records/services/config.py Outdated Show resolved Hide resolved
invenio_rdm_records/services/config.py Outdated Show resolved Hide resolved
invenio_rdm_records/services/config.py Show resolved Hide resolved
@0einstein0 0einstein0 force-pushed the Links-Update branch 2 times, most recently from ebaddd3 to 4d6f839 Compare August 26, 2024 11:51
@slint slint merged commit b717fb7 into inveniosoftware:master Aug 28, 2024
4 checks passed
slint added a commit to slint/zenodo-rdm that referenced this pull request Sep 2, 2024
@slint
installation: bump dependencies
1c46594 
📁 invenio-app-rdm (13.0.0b0.dev14 -> 13.0.0b1.dev3 ⚠️)

    📦 release: v13.0.0b1.dev3
    deposit: renamed get quota function
    config: filter out robots and flag machines
    migration: mint the new concept DOI for each upgraded record

    * previously, the script would create a new concept DOI for each record
      but never actually mint them on DataCite
    release: v13.0.0b1.dev2
    setup: bump invenio-communities
    release: v13.0.0b1.dev1
    ui: propagate permission check for community requests view

    * closes CERNDocumentServer/cds-rdm#158
    deposit form: provide props to overridable components

    * some of the overridable components have been using values that weren't
      passed as props
    sidebar: display 'Sizes' properly [+]

    - simplify formats as well
    config: add subjects datastream config
    share-modal: account for system created records
    release: v13.0.0b1.dev0
    setup: bump invenio-rdm-records
    records_ui: creatibutors: Display creator roles
    config: Bump records index version to v7.0.0
    AddUserGroupAccessModal: Use suggest API for finding users
    theme: adjust padding for community logo on record landing page

📁 invenio-communities (14.5.4 -> 15.0.0 ⚠️)

    release: v15.0.0
    mapping: add record_submission_policy to v2
    communities: Use accent analyzer for i18n titles
    fix: revert v1.0.0 changes
    communities: Move mappings to v2 and add accent analyzer
    mappings: add edge_ngram prefix search for community titles
    release: v14.10.0
    community settings: handle record submission policy setting

    * closes CERNDocumentServer/cds-rdm#158
    Fixing bug inveniosoftware/invenio-communities#1191
    release: v14.9.0
    bump invenio-vocabularies
    release: v14.8.0
    setup: bump invenio-requests
    InvitationsModal: Use suggest API for finding users
    📦 release: v14.7.0
    📦 release: v14.5.4
    package: bump react-invenio-forms
    📦 release: v14.5.3
    http headers: use and adjust vnd.inveniordm.v1+json http accept header

    * closes zenodo/rdm-project#598
    package: bump react-invenio-forms
    release: v14.6.1
    permissions: add excludes to review police generator
    i18n:push translations
    release: v14.6.0
    http headers: use and adjust vnd.inveniordm.v1+json http accept header

    * closes zenodo/rdm-project#598
    📦 release: v14.5.2
    user_moderation: dispatch Celery tasks for each community operation
    fix(logo): not fully deleted

    * logo file hasn't been deleted. this prevented a new file upload,
      because of an sqlalchemy.exc.IntegrityError:
      (psycopg2.errors.UniqueViolation) error.
    subcommunities: fix missing double-quote in email templates
    Invitation: Update RichEditor to use inputValue
    permissions: add member policy generator
    review police: allow all community members to submit records to community without review

    * closes CERNDocumentServer/cds-rdm#176
    user_moderation: dispatch Celery tasks for each community operation
    js+service: [zenodo#855] 4) integrate request flow with frontend [+]

    This concludes the 2nd flow of the membership request feature.
    Remaining flows are
    - 'waiting for decision' flow
    - 'making a decision' flow

    This PR needs to be complemented by:
    - one in invenio-requests (done)
    - one in invenio-rdm-records (to do)
    resources: [zenodo#855] add POST request_membership
    permissions: add can_request_membership
    header-ui: [zenodo#855] add inert request membership button+modal
    settings-ui: [zenodo#855] set membership policy
    fix(logo): not fully deleted

    * logo file hasn't been deleted. this prevented a new file upload,
      because of an sqlalchemy.exc.IntegrityError:
      (psycopg2.errors.UniqueViolation) error.
    subcommunities: fix missing double-quote in email templates
    fix(verified): the owner is not exclusively a user

    * a group could also be the first owner of a community and therfore
      break the key access

📁 invenio-jobs (0.4.0 -> 0.5.0 🌈)

    release: v0.5.0
    setup: bump invenio-users-resources

📁 invenio-rdm-records (11.8.0 -> 12.1.0 ⚠️)

    📦 release: v12.1.0
    config: added links for thumbnails (inveniosoftware/invenio-rdm-records#1799)
    📦 release: v12.0.4
    stats: add missing "is_machine" field
    release: v12.0.3
    communities: add permission checks for submission policy

    * closes CERNDocumentServer/cds-rdm#158
    release: v12.0.2
    setup: bump invenio-communities
    config: updated file quota and size vars
    quota: update func and variable config
    files: added config for media_files bucket
    release: v12.0.1
    setup: bump invenio-vocabularies
    release: v12.0.0
    records: mappings: Add extra fields to default search fields list
    records: mappings: Move settings to top of json
    records: jsonschemas: revert back to v6.0.0
    records: mappings: preserve original title and analyze more fields
    mappings: Remove v7 mappings from elasticsearch
    records: mappings: v7.0.0: Add missing fields
    records: update index settings for accent search

📁 invenio-requests (4.7.0 -> 5.0.0 ⚠️)

    release: v5.0.0
    setup: bump invenio-user-resources
    i18n:push translations

📁 invenio-stats (4.1.0 -> 4.2.0 🌈)

    📦 release: v4.2.0
    processors: allow filtering out robots/machines

📁 invenio-users-resources (5.4.0 -> 6.0.0 ⚠️)

    release: v6.0.0
    users: mappings: Add accent analyzing
    search: use email tokeniser as default search analyzer
    refactor: move to v3 as types have changed
    mappings: change from ngram to edge_ngram
    mappings: add ngram analyzer

    * Allows partial matches on search
    * closes CERNDocumentServer/cds-rdm#114
    i18n:push translations

📁 invenio-vocabularies (4.5.0 -> 5.0.2 ⚠️)

    📦 release: v5.0.2
    ror: use datePublished as fallback date for dataset timestamp
    release: v5.0.1
    mapping: fix normalizer

    * normalizers cannot preserve original value
      otherwise it will create 2 tokens for the keyword
    setup: fix module description
    release: v5.0.0
    vocabularies: Use specific index_name
    affiliations: Add lazy loaded localized title field for searching
    funders: mappings: Use accent edge analyzer instead of search_as_you_type
    affiliations: mappings: Use accent edge analyzer instead of search_as_you_type
    affiliations: Add reference doc link for fuzziness
    affiliations: Add preserve_original to filters in mappings
    affiliations: Add accent analyzer to mappings
    fix: schema_path
    mappings: remove edge_ngram from awards, move others to v2
    mappings: add edge_ngram prefix search
    📦 release: v4.5.0
    ci: run on maint/feature branches
    ror: fix dump modified date comparison
    ror: fix dump modified date comparison
    names: mappings: Use accent edge analyzer instead of search_as_you_type
    names: mappings: Move settings to top of json
    names: Add preserve_original to filters in mappings
    contrib: names: update field boosts and mapping
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slint slint slint approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Sprint Q3/2024: Vocabularies and friends
Status: To deploy
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0einstein0 @slint