Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add option that allows to include commit bodies in changelog #606

Merged
merged 2 commits into from
Dec 1, 2023

Conversation

lesnitsky
Copy link
Contributor

Description

This PR introduces a new version command option:

command:
  version:
    includeCommitBody: true # default is false

This might be useful for PRs with breaking changes (migration guides could be added to changelog from commit boides)

Type of Change

  • feat -- New feature (non-breaking change which adds functionality)
  • 🛠️ fix -- Bug fix (non-breaking change which fixes an issue)
  • ! -- Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 refactor -- Code refactor
  • ci -- Build configuration change
  • 📝 docs -- Documentation
  • 🗑️ chore -- Chore

@lesnitsky
Copy link
Contributor Author

Example changelog produced with includeCommitBody: true

firebase_ui_storage - v2.0.0

  • BREAKING FEAT(ui_storage): upgrade uuid dependency to ^4.0.0 (#188). (e85c5166)

    UuidFileUploadNamingPolicy and respective factory constructor FileUploadNamingPolicy.uuid now accept V4Options?, instead of Map<String, dynamic>?.

    Here's an example migration:

    final config = FirebaseUIStorageConfiguration(
      storage: storage,
    -  namingPolicy: FileUploadNamingPolicy.uuid({ 'rng': CryptoRNG() }),
    +  namingPolicy: FileUploadNamingPolicy.uuid(V4Options(null, CryptoRNG())),
    );
    
    await FirebaseUIStorage.configure(config);

firebase_ui_auth - v1.11.0

  • FIX(ui_auth): correctly position phone input screen footer (#183). (d5e2338d)

  • FIX(ui_auth): make maxWidth configurable on all screens (#178). (c5e77c27)

  • FEAT(ui_auth): export localizedErrorText (#189). (ab89f5cf)

    When ErrorText.localizeError is used, it becomes a single source of truth.
    This means all error messages should be localized by developer.
    A subset of errors is already localized by Firebase UI, so localizedErrorText that is
    used internally is now public and could be used inside ErrorText.localizeError.

    ErrorText.localizeError = (BuildContext context, FirebaseAuthException e) {
      if (e.code == "user-not-found" || e.code == "wrong-password") return "Wrong credentials";
    
      final defaultLabels = FirebaseUILocalizations.labelsOf(context);
      return localizedErrorText(e.code, defaultLabels);
    }
  • FEAT(ui_auth): confirm account deletion (#187). (053a96ee)

    ProfileScreen and DeleteAccountButton now have showDeleteConfirmationDialog.
    If set to true, user will be presented a dialog asking to confirm this action.

@spydon
Copy link
Collaborator

spydon commented Nov 30, 2023

Just a heads up that with this activated one is unfortunately going to run into the max changelog size very quickly on pub.dev so might be worth mentioning that in the docs, otherwise I think that it looks good!

Would be nice if it would be configurable to only take the commit body on breaking changes, but that's probably outside of the scope for this PR of course.

@lesnitsky
Copy link
Contributor Author

one is unfortunately going to run into the max changelog size very quickly on pub.dev

I didn't know there is such a limit 😮
Do you know what the max size currently?

@lesnitsky
Copy link
Contributor Author

Would be nice if it would be configurable to only take the commit body on breaking changes

Done

@spydon
Copy link
Collaborator

spydon commented Nov 30, 2023

I didn't know there is such a limit 😮 Do you know what the max size currently?

256KB - dart-lang/pub-dev#6012

Done

Amazing! That will be super helpful for Flame.

Copy link
Collaborator

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good!
Some docs would be good though

@Salakar Salakar merged commit 524e58a into main Dec 1, 2023
10 checks passed
@Salakar Salakar deleted the feat/changelog-commit-bodies branch December 1, 2023 13:31
@Salakar
Copy link
Member

Salakar commented Dec 1, 2023

Let's follow up with a docs PR, @lesnitsky lmk if you want me to do it.

This is published in 3.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants