Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Use the pubspec_parse package for parsing #794

Merged
merged 5 commits into from
Nov 20, 2024

Conversation

spydon
Copy link
Collaborator

@spydon spydon commented Nov 19, 2024

Description

Since the pubspec package is deprecated this PR refactors and cleans up the code by using the official pubspec_parse package.

Closes: #778

Since this is a pretty big change we should maybe release it as a pre-release version first.

Type of Change

  • feat -- New feature (non-breaking change which adds functionality)
  • 🛠️ fix -- Bug fix (non-breaking change which fixes an issue)
  • ! -- Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 refactor -- Code refactor
  • ci -- Build configuration change
  • 📝 docs -- Documentation
  • 🗑️ chore -- Chore

Copy link

docs-page bot commented Nov 19, 2024

To view this pull requests documentation preview, visit the following URL:

docs.page/invertase/melos~794

Documentation is deployed and generated using docs.page.

@spydon spydon requested a review from Salakar November 19, 2024 22:35
@spydon spydon merged commit df0c294 into main Nov 20, 2024
10 checks passed
@spydon spydon deleted the refactor/use-pubspec-parse branch November 20, 2024 11:58
@MarkOSullivan94
Copy link

@spydon I noticed your comment here

#778 (comment)

Why did you use pubspec_parse and not pubspec_manager?

@spydon
Copy link
Collaborator Author

spydon commented Nov 20, 2024

@spydon I noticed your comment here

#778 (comment)

Why did you use pubspec_parse and not pubspec_manager?

Because we only needed it for parsing (and it's the official pubspec parsing package), and it also has a cleaner API imho.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

request: Migrate away from discontinued pubspec package
3 participants