feat(android): simple installation #414
Conversation
|
ooh thanks for this p/r 😍 it looks like it should work 👀 I'll double-check locally, and I'll kick off the jobs. Would you be able to sign the cla? Thank you! |
There was a problem hiding this comment.
The CI failures seem both real and unrelated to this PR
- jest is failing and has been for a few builds, looks like ts-jest module is missing somehow
- iOS build is failing because Podfile and Podfile.lock are out of sync
Not sure when this happens but it looks like an incomplete dependency update happened at some point. That's usually me doing dependency updates so perhaps I made a mistake along the road somewhere. Either way this will definitely simplify the android installation if it works, curious for @helenaford testing results, at the same time, I think this PR would be most complete if the tests_react_native app removed the repository definition in order for this to actually be exercised in CI -
notifee/tests_react_native/android/build.gradle
Lines 39 to 41 in c2050f1
as well as the example
There was a problem hiding this comment.
Nice!
The CI failures seem both real and unrelated to this PR
- jest is failing and has been for a few builds, looks like ts-jest module is missing somehow
- iOS build is failing because Podfile and Podfile.lock are out of sync
Not sure when this happens but it looks like an incomplete dependency update happened at some point. That's usually me doing dependency updates so perhaps I made a mistake along the road somewhere. Either way this will definitely simplify the android installation if it works, curious for @helenaford testing results, at the same time, I think this PR would be most complete if the tests_react_native app removed the repository definition in order for this to actually be exercised in CI -
notifee/tests_react_native/android/build.gradle
Lines 39 to 41 in c2050f1
as well as the example
and the example construction script
notifee/packages/react-native/refresh-example.sh
Lines 38 to 39 in c2050f1
That will purge it out of everywhere and then CI will demonstrate whether it works or not I think?
| "dependencies": { | ||
| "@notifee/react-native": "github:notifee/react-native-notifee", | ||
| "@notifee/react-native": "link:../", |
There was a problem hiding this comment.
I linked to the current project to check the build with changes, please let me know if a revert is needed!
There was a problem hiding this comment.
I feel like this was there for some reason, but in retrospect I can't remember what it is. I think the link to local is better personally and I'd like it to work. Willing to go with it and see if it works, personally
| @@ -24,15 +23,5 @@ const setCompileSdkVersion = (buildGradle: string): string => { | |||
| return buildGradle.replace(/compileSdkVersion = 30/, `compileSdkVersion = 31`); | |||
| }; | |||
|
|
|||
| const setMavenRepository = (projectBuildGradle: string): string => { | |||
There was a problem hiding this comment.
Oh you got the expo plugin too, I forgot about it 🤦 - nicely done
There was a problem hiding this comment.
I'd never know if you hadn't told me about the tests. 👍
|
Believe it or not, the CI e2e android test is encouraging - it did fail, but it did build, failure is just a flaky test. |
|
I attached a jest result screenshot ran from my local ! If there is a high rate that tests cannot be performed because the |
|
thank you!! Merging! And about to release 😎 |
|
@mikehardy @helenaford Thank you! |
| @@ -87,3 +87,10 @@ ReactNative.shared.applyPackageVersion() | |||
| ReactNative.shared.applyDefaultExcludes() | |||
| ReactNative.module.applyAndroidVersions() | |||
| ReactNative.module.applyReactNativeDependency("api") | |||
| rootProject.allprojects { | |||
There was a problem hiding this comment.
@christocracy - you might like this, removes an error-prone install step for react-native repos with local maven repositories to load aars, appears to work fine for us here, could clean up my app build files from background-fetch and geolocation-android :-)
Hello Team, thank you for always supporting high-quality open source!
I got the idea from react-native-gradle and simplifies the installation.
It works, but I'm not sure of any side effects because I don't have deep knowledge of groovy.
so feel free to comment. thank you!