Web - Facebook Sign In #7
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ive-firebase.d.ts)
# Conflicts: # template/src/app/auth-providers/Google.tsx
# Conflicts: # template/src/app/auth-providers/Google.tsx
# Conflicts: # template/src/app/auth-providers/Google.tsx # template/src/app/signed-in/Settings.tsx # template/src/shims/firebase-auth-web.ts
# Conflicts: # template/src/app/auth-providers/Facebook.tsx # template/src/app/signed-in/Settings.tsx
|
FWIW - a rebase merge is a much much cleaner way to do development as it leaves a clean commit trail, this one is a real hash now - there are 18 commits for one feature 🤔 - I'm still on holidays though and have this queued for as soon as I return when I can start cleaning up my todo list for the new year :) |
|
Oh sorry about that, will keep that in mind. There are so many commits because I have the changes with the Google Sign in as well. The login on web seems to work well, but other than logging, there's no support yet. I'm on holidays as well, though I have to admit, those are the worst holidays in my life, but working with React Native is a good anti-depressant for me 😂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the changes from on #6 as well,
It adds limited Facebook and Google functionality on the web using Firebase. But for demonstration purposes, I think it's sufficient.