Skip to content

Commit

Permalink
test(e2e, emulator): execute emulator start directly, not via sh
Browse files Browse the repository at this point in the history
using sh caused problems when executing on linux, though it worked on mac
the executable bit is set on the script though and I verified it works
when executed directly on both linux and mac
  • Loading branch information
mikehardy committed Apr 30, 2021
1 parent 2413c6b commit 3396da2
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@
"tests:packager:chrome": "cd tests && node_modules/.bin/react-native start --reset-cache",
"tests:packager:jet": "cd tests && cross-env REACT_DEBUGGER=\"echo nope\" node_modules/.bin/react-native start --no-interactive",
"tests:packager:jet-reset-cache": "cd tests && cross-env REACT_DEBUGGER=\"echo nope\" node_modules/.bin/react-native start --reset-cache --no-interactive",
"tests:emulator:start": "cd ./.github/workflows/scripts && sh ./start-firebase-emulator.sh --no-daemon",
"tests:emulator:start-ci": "cd ./.github/workflows/scripts && sh ./start-firebase-emulator.sh",
"tests:emulator:start": "cd ./.github/workflows/scripts && ./start-firebase-emulator.sh --no-daemon",
"tests:emulator:start-ci": "cd ./.github/workflows/scripts && ./start-firebase-emulator.sh",
"tests:android:build": "cd tests && ./node_modules/.bin/detox build --configuration android.emu.debug",
"tests:android:build-release": "cd tests && ./node_modules/.bin/detox build --configuration android.emu.release",
"tests:android:test": "cd tests && ./node_modules/.bin/detox test --configuration android.emu.debug",
Expand Down

1 comment on commit 3396da2

@vercel
Copy link

@vercel vercel bot commented on 3396da2 Apr 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.