-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔥[🐛] Failed resolution of: Landroidx/browser/customtabs/CustomTabsIntent$Builder; #4744
Comments
Interesting, you did not provide any android build.gradle details so I can't see if you've overridden firebase-android-sdk BoM version. If you have not overridden it and the package.json snippet you included (with react-native-firebase 10.4.0) is accurate then you are on current release of firebase-android-sdk, i.e. 26.2.0
Can you confirm that is the case, that you are on firebase-android-sdk 26.2.0? If you are on 26.2.0 and still reproduce this, the upstream issue needs a reopen and a fix, and we may issue a workaround here. If you are not on 26.2.0 please update to do that and check if it fixes it or not and go from there |
I included more android files. I am not aware of any override. I am not sure what is BoM version. Here is trimmed output of all dependencies. As far I can see I am using 26.2.0 version. I somehow believe that I am just doing something wrong, since it was already fixed upstream.
|
Cool - thanks for showing that. You are using 26.2.0 so this is still an issue. It wasn't fixed upstream, it was just closed for lack of activity. It appears it should be reopened. I'll head over there and see what I can do. We may work around it here but in the meantime you will definitely need the dependency in your project it seems |
Thank you for such a quick response. As there is a simple workaround, there is no need for any imediate action. We can wait until it is fixed upstream. Let me me know if I can be any help and thank you for your amazing work. |
I am having the same issue running on AVDs
|
@SoLoHK525 it can happen anytime for a variety of reasons. Showing the web recaptcha flow is the standard backup flow for authentication. If the workaround works for you, you're all set. |
We would love a PR to enable the setting of the new toggle which forces the ReCAPTCHA flow actually: https://rnfirebase.io/reference/auth/authsettings is the settings object in react-native-firebase that wraps as of November / android BoM 26.1.0 https://firebase.google.com/support/release-notes/android#auth_v20-0-1 Then you can check this easily, any time |
The reCAPTCHA auth flow requires androidx.browser but it is not specified as a transitive dependency upstream, so it crashes. I attempted to use as wide a version range as I felt safe, and provided an override if you specify "androidxBrowserVersion" in your android/build.gradle ext config block Related #4744 Related firebase/firebase-android-sdk#2164 This may be removed when the upstream issue is closed.
The reCAPTCHA auth flow requires androidx.browser but it is not specified as a transitive dependency upstream, so it crashes. I attempted to use as wide a version range as I felt safe, and provided an override if you specify "androidxBrowserVersion" in your android/build.gradle ext config block Related #4744 Related firebase/firebase-android-sdk#2164 This may be removed when the upstream issue is closed.
In v10.6.4 I have shipped a workaround that includes the androidx.browser dependency:
...so this should not crash anyone anymore I'm going to leave this open though, as it is an upstream bug and a workaround is not the same as a fix. |
Just waiting on
|
I can see it resolving correctly now in react-native-firebase v12.0.0 via
Closable! Will remove the workaround |
Previous versions of firebase-android-sdk did not express their dependency on androidx.browser library but used it for reCAPTHCA flow, leading to crashes. We had to temporarily add a dependency here/downstream to work around. Upstream has the dependency now, verified via `./gradlew :app:dependencies` Fixes #4744
Previous versions of firebase-android-sdk did not express their dependency on androidx.browser library but used it for reCAPTHCA flow, leading to crashes. We had to temporarily add a dependency here/downstream to work around. Upstream has the dependency now, verified via `./gradlew :app:dependencies` Fixes #4744
The reCAPTCHA auth flow requires androidx.browser but it is not specified as a transitive dependency upstream, so it crashes. I attempted to use as wide a version range as I felt safe, and provided an override if you specify "androidxBrowserVersion" in your android/build.gradle ext config block Related invertase#4744 Related firebase/firebase-android-sdk#2164 This may be removed when the upstream issue is closed.
Previous versions of firebase-android-sdk did not express their dependency on androidx.browser library but used it for reCAPTHCA flow, leading to crashes. We had to temporarily add a dependency here/downstream to work around. Upstream has the dependency now, verified via `./gradlew :app:dependencies` Fixes invertase#4744
🔥Issue
This issue only occurs on Huawei phone when doing phone authentification. Newest Huawei phones does no contain Google Mobile Services. Normaly would phone use GMS to perform check of the user before SMS authentification. Since GMS is not available on the phone there is a fallback solution using Captcha. More info about it is here https://firebase.google.com/docs/auth/android/phone-auth#enable-app-verification
This issue occurs rightt after calling
auth().signInWithPhoneNumber(phoneNumber)
. App is trying to open browser and load captcha website.Solution
As described in firebase/firebase-android-sdk#2164 (comment) solution is to add dependency on browser into build.gradle
Question
Should react-native-firebase include this dependency on browser? If not please close this issue and keep it as a reference.
LogCat
Project Files
Javascript
Click To Expand
package.json
:firebase.json
for react-native-firebase v6:# N/A
AppDelegate.m
:// N/A
Android
Click To Expand
Have you converted to AndroidX?
android/gradle.settings
jetifier=true
for Android compatibility?jetifier
for react-native compatibility?android/build.gradle
:android/app/build.gradle
:android/settings.gradle
:MainApplication.java
:AndroidManifest.xml
:<!-- N/A -->
Environment
Click To Expand
react-native info
output:react-native-firebase
version you're using that has this issue:10.4.0
Firebase
module(s) you're using that has the issue:Auth
TypeScript
?Y
&4.1.3
The text was updated successfully, but these errors were encountered: