-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle UNUserNotificationCenter completionHandlers #1803
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1803 +/- ##
=======================================
Coverage 76.11% 76.11%
=======================================
Files 72 72
Lines 1838 1838
=======================================
Hits 1399 1399
Misses 439 439 |
2 similar comments
Codecov Report
@@ Coverage Diff @@
## master #1803 +/- ##
=======================================
Coverage 76.11% 76.11%
=======================================
Files 72 72
Lines 1838 1838
=======================================
Hits 1399 1399
Misses 439 439 |
Codecov Report
@@ Coverage Diff @@
## master #1803 +/- ##
=======================================
Coverage 76.11% 76.11%
=======================================
Files 72 72
Lines 1838 1838
=======================================
Hits 1399 1399
Misses 439 439 |
Codecov Report
@@ Coverage Diff @@
## master #1803 +/- ##
==========================================
+ Coverage 76.11% 76.16% +0.05%
==========================================
Files 72 72
Lines 1838 1838
==========================================
+ Hits 1399 1400 +1
+ Misses 439 438 -1 |
@blankg thanks for making those changes and replying to my points. It all makes sense now, sorry about the confusion 🙈 I'll go ahead and merge this now for the v5.2.0 release. Loving
|
Summary
Currently only didReceiveRemoteNotification: fetchCompletionHandler: are handle async by the JS complete method. This allows some time to perform tasks in background however the userNotificationCenter: didReceiveNotificationResponse: withCompletionHandler completion handler is called immediately which means not much time to perform tasks in background (about 1 sec from my experience) and calling complete from JS is meaningless.
This enhancement handles the NSUserNotificationCenter completionHandler in a similar way the fetchCompletionHandler is handled.
Checklist
Android
iOS
e2e
tests added or updated in /tests/e2e/*Test Plan
Release Plan
[IOS][ENHANCEMENT] [NOTIFICATIONS] - handle NSUserNotificationCenter completion handlers
Think
react-native-firebase
is great? Please consider supporting the project with any of the below:React Native Firebase
andInvertase
on Twitter