[IOS][BUGFIX] [DynamicLinks] Retry resolving the dynamic link once when the error is an ECONNABORTED #1841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
benschell
changed the title
Codecov Report
@@ Coverage Diff @@
## master #1841 +/- ##
=======================================
Coverage 78.22% 78.22%
=======================================
Files 63 63
Lines 1510 1510
=======================================
Hits 1181 1181
Misses 329 329 |
3 similar comments
Codecov Report
@@ Coverage Diff @@
## master #1841 +/- ##
=======================================
Coverage 78.22% 78.22%
=======================================
Files 63 63
Lines 1510 1510
=======================================
Hits 1181 1181
Misses 329 329 |
Codecov Report
@@ Coverage Diff @@
## master #1841 +/- ##
=======================================
Coverage 78.22% 78.22%
=======================================
Files 63 63
Lines 1510 1510
=======================================
Hits 1181 1181
Misses 329 329 |
Codecov Report
@@ Coverage Diff @@
## master #1841 +/- ##
=======================================
Coverage 78.22% 78.22%
=======================================
Files 63 63
Lines 1510 1510
=======================================
Hits 1181 1181
Misses 329 329 |
Salakar
approved these changes
Jan 17, 2019
|
@benschell thank you for this, all is good here and master is fine 👌 will go ahead and merge for the v5.3.x pipeline. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I ran into the issue described in #1589 ; specifically, a ECONNABORTED when returning to my app (while the app was in the background) from a click on a dynamic link (in my case, it was specifically a password-less email login link).
The comments in that issue pointed to some suggested workarounds present in a discussion on AFNetworking; I specifically read through this comment https://github.com/AFNetworking/AFNetworking/issues/4279#issuecomment-447108981 and implemented suggested workaround (B) which was to, in the case of this specific error condition, retry the request.
I'm not sure if this should be against a point-release branch instead of master, please forgive me if it's pointing to the wrong branch.
Checklist
AndroidiOSe2etests added or updated in /tests/e2e/*Test Plan
Release Plan
[IOS][BUGFIX] [DynamicLinks] - Fixed a bug where dynamic links were not handled properly on iOS when returning from a background state
🔥