-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ANDROID][BUGFIX][ADMOB] Fix Admob crash from UnityAds with Admob Mediation #1892
Conversation
Are we running out of money to run circleCI ?? |
We have 😭 I'll sort for next week! |
aaahhhh okay..! Thanks for your quick response! |
can we rerun circleCI? |
Hi there! I'm helping maintain the v5 branch along with @Salakar and I believe we have CI all sorted and tests green etc so the v5 branch can tolerate change now. If you rebase to current v5.x.x and push this again, I can check into it and try to get it merged for you. @wasedaigo what do you think? |
I was able to rebase via github UI so I'll check into this once CI check goes green |
This will be in the next 5.4.x release - thanks! |
Fixes #1792
Summary
There is a problem that UnityAds does not work with Admob Mediation.
It seems some mediation adapters such as UnityAds, adcolony, appodeal require ActivityContext.
This PR fixes the issue.
Checklist
[ x] Supports
Android
Supports
iOS
e2e
tests added or updated in /tests/e2e/*Updated the documentation in the docs repo
Flow types updated
Typescript types updated
Test Plan
My fork is already released for my games in production.
I started seeing getting a traffic to UnityAds via AdmobMediation which used to be zero.
So far I am not seeing any obvious bug due to this change, but I have no idea how to make sure this change won't introduce any regression.
Release Plan
[ANDROID][BUGFIX][ADMOB] - Fixed an issue UnityAds wasn't working with Admob Mediation due to the lack of ActivityContext