Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ANDROID][BUGFIX][ADMOB] Fix Admob crash from UnityAds with Admob Mediation #1892

Merged
merged 2 commits into from
Jun 10, 2019

Conversation

wasedaigo
Copy link
Contributor

@wasedaigo wasedaigo commented Feb 10, 2019

Fixes #1792

Summary

There is a problem that UnityAds does not work with Admob Mediation.
It seems some mediation adapters such as UnityAds, adcolony, appodeal require ActivityContext.
This PR fixes the issue.

Checklist

  • [ x] Supports Android

  • Supports iOS

  • e2e tests added or updated in /tests/e2e/*

  • Updated the documentation in the docs repo

    • LINK TO DOCS PR HERE
  • Flow types updated

  • Typescript types updated

Test Plan

My fork is already released for my games in production.
I started seeing getting a traffic to UnityAds via AdmobMediation which used to be zero.
So far I am not seeing any obvious bug due to this change, but I have no idea how to make sure this change won't introduce any regression.

Release Plan

[ANDROID][BUGFIX][ADMOB] - Fixed an issue UnityAds wasn't working with Admob Mediation due to the lack of ActivityContext

@wasedaigo
Copy link
Contributor Author

wasedaigo commented Feb 10, 2019

Blocked due to plan-no-credits-available Please purchase a new credit block then push a new commit or call the API to run a new build.

Are we running out of money to run circleCI ??

@Salakar
Copy link
Member

Salakar commented Feb 10, 2019

Are we running out of money to run circleCI ??

We have 😭 I'll sort for next week!

@wasedaigo
Copy link
Contributor Author

aaahhhh okay..! Thanks for your quick response!

@wasedaigo
Copy link
Contributor Author

can we rerun circleCI?

@mikehardy
Copy link
Collaborator

Hi there! I'm helping maintain the v5 branch along with @Salakar and I believe we have CI all sorted and tests green etc so the v5 branch can tolerate change now. If you rebase to current v5.x.x and push this again, I can check into it and try to get it merged for you. @wasedaigo what do you think?

@mikehardy
Copy link
Collaborator

I was able to rebase via github UI so I'll check into this once CI check goes green

@mikehardy mikehardy changed the title [ANDROID][BUGFIX][ADMOB] Fixing UnityAds not working with Admob Mediation [ANDROID][BUGFIX][ADMOB] Fix Admob crash from UnityAds with Admob Mediation Jun 10, 2019
@mikehardy mikehardy merged commit 01e6dd4 into invertase:v5.x.x Jun 10, 2019
@mikehardy
Copy link
Collaborator

This will be in the next 5.4.x release - thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact: crash Behaviour causing app to crash. plugin: admob Google AdMob
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants