fix(firestore): correctly apply internal __name__ query modifier (fixes #2854)
#2866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
Codecov Report
@@ Coverage Diff @@
## master #2866 +/- ##
==========================================
- Coverage 88.95% 88.69% -0.25%
==========================================
Files 111 111
Lines 3436 3437 +1
==========================================
- Hits 3056 3048 -8
- Misses 380 389 +9 |
Salakar
added
platform: javascript
plugin: firestore
|
iOS CI failure unrelated, but has highlighted another issue - so will fix separately |
1 task
androidIsForVivek
pushed a commit
to androidIsForVivek/react-native-firebase
that referenced
this pull request
Aug 9, 2021
…ertase#2866) * fix(firestore): correctly apply internal `__name__` query modifier (fixes invertase#2854) * chore(tests): cleanup unnecessary code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Correctly apply internal
__name__Firestore query modifier (fixes #2854)Checklist
AndroidiOSe2etests added or updated in packages/**/e2e