fix(firestore): update isEqual API to check collection path equality #3738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Salakar
approved these changes
Jun 3, 2020
stefkampen
pushed a commit
to stefkampen/react-native-firebase
that referenced
this pull request
Jun 6, 2020
…nvertase#3738) * fix(firestore): update isEqual check * test(firestore): test isEqual condition Co-authored-by: Mike Diarmid <mike.diarmid@gmail.com> [publish]
5 tasks
androidIsForVivek
pushed a commit
to androidIsForVivek/react-native-firebase
that referenced
this pull request
Aug 9, 2021
…nvertase#3738) * fix(firestore): update isEqual check * test(firestore): test isEqual condition Co-authored-by: Mike Diarmid <mike.diarmid@gmail.com> [publish]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per this v5 PR, we ought to check that collection paths are different when checking if the query is the same using
isEqualAPI.I also updated the mocha file because the nested Firestore tests aren't being captured. Not sure if this is by design however.