fix(storage): Changed refFromUrl regex to exclude appspot.com #3775
Conversation
dackers86
requested review from
Salakar,
Ehesp,
mikehardy and
russellwheatley
and removed request for
mikehardy
dackers86
changed the title
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/invertase/react-native-firebase/qkk91rk83 |
mikehardy
added
the
Workflow: Needs Review
ios sends a 'storage/storage/file-not-found' while android sends 'storage/file-not-found' pause/resume works locally but can fail in CI canceling was timing out locally Ideally there would be underlying fixes but the point of this PR is to re-enable the tests in general, so having them running at all (in the majority) is a major win and worth getting in quickly
mikehardy
force-pushed
the
@dackers86/fix-ref-url-domain
branch
from
1875a70 to
2a21f7a
Compare
There was a problem hiding this comment.
@dackers86 finally unwinding some of the PR stack! This one looks fine, I de-merge-committed it, stripped it down to just the commits doing real changes and rebased it against master so it was clean+easy-to-review and it seems to pass everything locally
This is the one that re-enables the storage tests so I'm excited to get it in prior to the big breaking change about to land
Cheers
Codecov Report
@@ Coverage Diff @@
## master #3775 +/- ##
=======================================
Coverage 41.92% 41.92%
=======================================
Files 35 35
Lines 1119 1119
Branches 278 278
=======================================
Hits 469 469
Misses 489 489
Partials 161 161 |
mikehardy
added
Workflow: Pending Merge
Fix for issue #2753.
When extracting the url, regex currently excludes appspot.com. This has now been included so that the domain is included.
Format changed from {bucket} to {bucket}.appspot.com