Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(firestore, android): allow FirestoreSerializer native use #3888

Merged
merged 1 commit into from
Jul 6, 2020

Conversation

mikehardy
Copy link
Collaborator

Description

I have a brownfield use case where I do some firestore things in native code while doing most in Javascript.
For best code re-use in the app I sometimes want to send objects to the native code for further decoration before persisting to Firestore

Being able to re-use the existing serializer for that would be fantastic, and it's just two "public" markings away...

Release Summary

feat(firestore, android): allow FirestoreSerializer native re-use in brownfield apps

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan

Using it already in my project via patch-package


Think react-native-firebase is great? Please consider supporting the project with any of the below:

@mikehardy mikehardy requested a review from Salakar July 6, 2020 20:36
Copy link
Member

@Salakar Salakar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Salakar Salakar changed the title feat(firestore, android): allow FirestoreSerializer native re-use in brownfield apps feat(firestore, android): allow FirestoreSerializer native use Jul 6, 2020
@Salakar Salakar merged commit 68daf94 into invertase:master Jul 6, 2020
@mikehardy mikehardy deleted the public-firestore-serializer branch August 12, 2020 03:33
androidIsForVivek pushed a commit to androidIsForVivek/react-native-firebase that referenced this pull request Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants