Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(database, types): harmonize database.on() w/firebase-js-sdk #5141

Merged
merged 1 commit into from
Apr 9, 2021

Conversation

mikehardy
Copy link
Collaborator

Description

This builds on the work both upstream and in this repo of @SCasarotto

Related issues

Fixes #4545
Supercedes #4550
Upstream firebase-js-sdk firebase/firebase-js-sdk#4250

Release Summary

commit message is conventional, rebase merge

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan


Think react-native-firebase is great? Please consider supporting the project with any of the below:

This builds on the work both upstream and in this repo of @SCasarotto
from #4550
@vercel
Copy link

vercel bot commented Apr 8, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/invertase/react-native-firebase/7yWkZkW8vorA8b1pUNL43rgs1Nfn
✅ Preview: https://react-native-firebase-git-mikehardy-database-types-invertase.vercel.app

@mikehardy mikehardy added the Workflow: Pending Merge Waiting on CI or similar label Apr 8, 2021
@codecov
Copy link

codecov bot commented Apr 8, 2021

Codecov Report

Merging #5141 (a6a269b) into master (d2838ff) will not change coverage.
The diff coverage is n/a.

❗ Current head a6a269b differs from pull request most recent head f1eddb6. Consider uploading reports for the commit f1eddb6 to get more accurate results

@@           Coverage Diff           @@
##           master    #5141   +/-   ##
=======================================
  Coverage   88.99%   88.99%           
=======================================
  Files         109      109           
  Lines        3739     3739           
  Branches      358      358           
=======================================
  Hits         3327     3327           
  Misses        367      367           
  Partials       45       45           

@mikehardy mikehardy merged commit 6aea33f into master Apr 9, 2021
@mikehardy mikehardy deleted the @mikehardy/database-types branch April 11, 2021 13:55
@mikehardy mikehardy added Blocked: Missing CLA and removed Workflow: Pending Merge Waiting on CI or similar labels Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🐛] Type Definition Error in database Types
1 participant