-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: serverTimestampBehavior #5514
Conversation
This pull request is being automatically deployed with Vercel (learn more). react-native-firebase – ./🔍 Inspect: https://vercel.com/invertase/react-native-firebase/12bbMBbHWfSbWhheRpsWRQvshyoL react-native-firebase-next – ./website_modular🔍 Inspect: https://vercel.com/invertase/react-native-firebase-next/CxKaWMxp3yoeM9VPFTUscvxWFWpW [Deployment for d434196 failed] |
@mikehardy As far as I can tell this is done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not just "done" but with what looks like fantastic test support. This looks really good. Running it through CI now
Codecov Report
@@ Coverage Diff @@
## master #5514 +/- ##
============================================
+ Coverage 67.48% 67.54% +0.06%
- Complexity 980 983 +3
============================================
Files 189 199 +10
Lines 9523 9659 +136
Branches 1487 1510 +23
============================================
+ Hits 6426 6523 +97
- Misses 2686 2722 +36
- Partials 411 414 +3 |
Everything green except Vercel for react-native-firebase-next, but I don't have access to the details for that one. |
This still LGTM but in trying to fix the vercel deployment issue (which was a commit in the 20 commit delta between when you branched for your 3 and current) I blew up your commit state, sincere apologies. I've got the commits though and pushed them here: #5556 |
Description
Implements serverTimestampBehavior as a firestore setting.
It's currently impossible to implement SnapshotOptions as they work in the javascript sdk, this is the next best option in my opinion.
Related issues
Release Summary
Checklist
Android
iOS
e2e
tests added or updated inpackages/\*\*/e2e
jest
tests added or updated inpackages/\*\*/__tests__
Test Plan
Think
react-native-firebase
is great? Please consider supporting the project with any of the below:React Native Firebase
andInvertase
on Twitter