Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(build, ios): quiet non-RNFB warnings #5935

Merged
merged 6 commits into from
Dec 14, 2021
Merged

Conversation

mikehardy
Copy link
Collaborator

The build noise on iOS builds is outrageous but I don't want to quiet all warnings, just non-RNFB-pod ones

finally figured out how to do that, and here it is

@vercel
Copy link

vercel bot commented Dec 14, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

react-native-firebase – ./

🔍 Inspect: https://vercel.com/invertase/react-native-firebase/EemkKaeFHqEGf9BzKj6rymzMB3pY
✅ Preview: https://react-native-firebase-git-mikehardy-quiet-build-invertase.vercel.app

react-native-firebase-next – ./website_modular

🔍 Inspect: https://vercel.com/invertase/react-native-firebase-next/HoEyUxoKA1jRxkRJhtoVxctJq7vW
✅ Preview: Canceled

[Deployment for 4f5f5c4 canceled]

@codecov
Copy link

codecov bot commented Dec 14, 2021

Codecov Report

Merging #5935 (56dc524) into main (049886a) will decrease coverage by 27.36%.
The diff coverage is n/a.

❗ Current head 56dc524 differs from pull request most recent head 4f5f5c4. Consider uploading reports for the commit 4f5f5c4 to get more accurate results

@@              Coverage Diff              @@
##               main    #5935       +/-   ##
=============================================
- Coverage     52.66%   25.30%   -27.35%     
=============================================
  Files           208       97      -111     
  Lines         10157     4230     -5927     
  Branches       1612     1026      -586     
=============================================
- Hits           5348     1070     -4278     
+ Misses         4550     2566     -1984     
- Partials        259      594      +335     

…tatus report

the current xcode build is still very noisy

previously there was an issue with combination of xcpretty and CI, such that
compile failures were not detected and failing CI.

xcpretty is abandoned but xcbeautify lives. The built-in `-quiet` is too quiet.

I believe this combo of set -o pipefail and xcbeautify should do it.
It passes local negative- and positive-testing on build status reporting
this quiets linker errors since test project matches Podfile now
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant