-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(build, ios): quiet non-RNFB warnings #5935
Conversation
This pull request is being automatically deployed with Vercel (learn more). react-native-firebase – ./🔍 Inspect: https://vercel.com/invertase/react-native-firebase/EemkKaeFHqEGf9BzKj6rymzMB3pY react-native-firebase-next – ./website_modular🔍 Inspect: https://vercel.com/invertase/react-native-firebase-next/HoEyUxoKA1jRxkRJhtoVxctJq7vW [Deployment for 4f5f5c4 canceled] |
Codecov Report
@@ Coverage Diff @@
## main #5935 +/- ##
=============================================
- Coverage 52.66% 25.30% -27.35%
=============================================
Files 208 97 -111
Lines 10157 4230 -5927
Branches 1612 1026 -586
=============================================
- Hits 5348 1070 -4278
+ Misses 4550 2566 -1984
- Partials 259 594 +335 |
58cd3c0
to
b2b1c67
Compare
…tatus report the current xcode build is still very noisy previously there was an issue with combination of xcpretty and CI, such that compile failures were not detected and failing CI. xcpretty is abandoned but xcbeautify lives. The built-in `-quiet` is too quiet. I believe this combo of set -o pipefail and xcbeautify should do it. It passes local negative- and positive-testing on build status reporting
this quiets linker errors since test project matches Podfile now
b2b1c67
to
4f5f5c4
Compare
The build noise on iOS builds is outrageous but I don't want to quiet all warnings, just non-RNFB-pod ones
finally figured out how to do that, and here it is