Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(messaging): fix how to inject a isHeadless prop into the app #6876

Closed
wants to merge 1 commit into from

Conversation

VikalpP
Copy link

@VikalpP VikalpP commented Jan 31, 2023

Description

This PR updates the Firebase Messaging doc to inject isHeadless prop into the app using the AppDelegate.m file.
Since React Native has introduced New Architecture, code has changed in the AppDelegate.m file.
This PR simply updates as per new code changes where initProps is already declared as passed to the initial UIView.

Release Summary

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • This is a breaking change;
    • Yes
    • No

@vercel
Copy link

vercel bot commented Jan 31, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
react-native-firebase ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 31, 2023 at 6:08AM (UTC)
1 Ignored Deployment
Name Status Preview Comments Updated
react-native-firebase-next ⬜️ Ignored (Inspect) Jan 31, 2023 at 6:08AM (UTC)

@CLAassistant
Copy link

CLAassistant commented Jan 31, 2023

CLA assistant check
All committers have signed the CLA.

@VikalpP VikalpP changed the title docs: Fix doc to inject a isHeadless prop into the app docs(messaging): fix how to inject a isHeadless prop into the app Jan 31, 2023
@mikehardy
Copy link
Collaborator

Out of curiosity for the future - how does this change interact with the PR that just merged related to the same item, and which will (I think?) be in react-native 0.72? facebook/react-native#35848

@jblarriviere
Copy link
Contributor

I believe this PR (facebook/react-native#35848) is already in 0.71.1
I've just created this one #6877 to update messaging docs accordingly !

@mikehardy
Copy link
Collaborator

superceded by #6877

@mikehardy mikehardy closed this Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants