-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(app-check): Add support for Expo config plugin #7662
feat(app-check): Add support for Expo config plugin #7662
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Hi @mikehardy, was wondering if you need anything else to get this PR approved? It might look like a lot of changes but it essentially is a copy of the Expo plugin setup found in Dynamic Links but with a few strings changed. Much appreciated for all your hard work on this project 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry - whole family came down with good ol' COVID except me but I played the part of nurse. Everyone's fine :-), but I'm swamped with backlog now, that's for sure
This looks great, triggering CI after I commit the one change for Expo branch name
bd3cf07
to
e5874c0
Compare
There was a trivial error with lint and a failure to include the expo plugin as a dev dependency - I've resolved those and pushed back out the branch. If CI passes I'll merge this, thank you! |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #7662 +/- ##
===========================================
- Coverage 68.05% 33.36% -34.69%
===========================================
Files 149 252 +103
Lines 5943 12497 +6554
Branches 1250 1951 +701
===========================================
+ Hits 4044 4168 +124
- Misses 1802 8240 +6438
+ Partials 97 89 -8 |
Thanks for the approval and merge @mikehardy, hope your family is feeling better! |
Description
App Check needs additional setup in
AppDelegate
to work which is difficult in a managed Expo workflow.Created a Expo config plugin similar to other
react-native-firebase
packages such as the one found in Dynamic Links. The pull request code is also modeled after the Dynamic Links config plugin.Release Summary
Added support for Expo config plugin.
Checklist
Android
iOS
e2e
tests added or updated inpackages/\*\*/e2e
jest
tests added or updated inpackages/\*\*/__tests__
Test Plan
Tests have passed. Verified in iOS builds that the new config plugin will add lines as described in the App Check setup step.
Think
react-native-firebase
is great? Please consider supporting the project with any of the below:React Native Firebase
andInvertase
on Twitter🔥