-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(analytics): allow custom event parameters for Item in events #7908
feat(analytics): allow custom event parameters for Item in events #7908
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Hello 👋, this PR has been opened for more than 2 months with no activity on it. If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing! You have 15 days until this gets closed automatically |
Hello 👋, this PR has been opened for more than 2 months with no activity on it. If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing! You have 15 days until this gets closed automatically |
This is something I'm looking to use as well. Is there anything I can do to help this across the line? |
fde3d05
to
97888bf
Compare
97888bf
to
c19c009
Compare
Hey @dannyBies 👋 the commit trail in here was a mess and it had one unaddressed commit So if Russell re-reviews and agrees this is good to go Either way, my re-push had the side effect of re-running CI which means that the patch-package workflow re-runs and - if you follow the details link and check the summary of the patch packages worfklow you should find a patch set you can apply to your project that will work. Providing feedback on how it works is very useful |
Amazing, thanks for the extremely quick response, it's much appreciated! I'll have a look at using patch-package tomorrow. |
Description
We wanted to add custom parameters to the items for ecommerce events. Firebase supports it (https://developers.google.com/analytics/devguides/collection/ga4/item-scoped-ecommerce), but it was not yet supported by react-native-firebase.
This MR is inspired by #5811
Related issues
Release Summary
Checklist
Android
iOS
e2e
tests added or updated inpackages/\*\*/e2e
jest
tests added or updated inpackages/\*\*/__tests__
Test Plan
I added a test case.
Think
react-native-firebase
is great? Please consider supporting the project with any of the below:React Native Firebase
andInvertase
on Twitter