This repository has been archived by the owner on Sep 24, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 31
fix(deps, android)!: switch to local maven repo for aar dependency #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikehardy
force-pushed
the
@mikehardy/rn-aar-in-local-repo
branch
from
August 26, 2021 23:08
caf8a1e
to
0ad823f
Compare
I'm test integrating this into a work project to make sure it's good - first attempt to test it indicated it is not! :-) |
mikehardy
force-pushed
the
@mikehardy/rn-aar-in-local-repo
branch
2 times, most recently
from
August 27, 2021 03:04
fe6c89b
to
5f8a568
Compare
Okay, this works for me in my project with this reference: "@notifee/react-native": "github:notifee/react-native-notifee#5f8a5688b4faf56648f60696243681e3837d7715", ...and this in postinstall so it works from source: "postinstall": "patch-package && cd node_modules/@notifee/react-native && yarn" ...given I have this in my allprojects {
repositories {
// ...other repositories here...
maven {
url("$rootDir/../node_modules/@notifee/react-native/android/libs")
} I think it is good to go but it is a breaking change and we can't tell people in enough places about this little thing they need to add in |
mikehardy
added a commit
to notifee/documentation
that referenced
this pull request
Aug 27, 2021
…n android also added release note block for future release Related invertase/notifee#107 and invertase/react-native-notifee#370
mikehardy
force-pushed
the
@mikehardy/rn-aar-in-local-repo
branch
from
August 27, 2021 19:18
5f8a568
to
9a07693
Compare
Fixes #151 Fixes notifee/documentation#8 BREAKING CHANGE: add "maven { url "$rootDir/../node_modules/@notifee/react-native/android/libs" }" to "repositories" in "android/build.gradle"
mikehardy
force-pushed
the
@mikehardy/rn-aar-in-local-repo
branch
from
August 27, 2021 19:20
9a07693
to
f94edfa
Compare
helenaford
approved these changes
Sep 11, 2021
helenaford
added a commit
to notifee/documentation
that referenced
this pull request
Sep 12, 2021
…n android (#17) also added release note block for future release Related invertase/notifee#107 and invertase/react-native-notifee#370 Co-authored-by: Helena Ford <helenaellieford@gmail.com>
Salakar
pushed a commit
to invertase/notifee
that referenced
this pull request
Sep 23, 2021
…n android (#17) also added release note block for future release Related #107 and invertase/react-native-notifee#370 Co-authored-by: Helena Ford <helenaellieford@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #151
Fixes notifee/documentation#8
BREAKING CHANGE: add
maven { url "$rootDir/../node_modules/@notifee/react-native/android/libs" } }
to the group of
repositories
insideallprojects
inandroid/build.gradle
It will probably look like this after: