Let Input module kwarg accept strings #597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reduce complexity Removed unnecessary list conversion: The templates = list(templates) line is removed as it's not needed since we're iterating through the templates directly. Removed result initialization: The result variable initialization is removed as we're now returning directly from the loop if a match is found. Return directly on match: If a template matches, the function now returns the result of template.extract directly within the loop. Simplified OCR fallback: The OCR fallback logic is simplified by directly returning the result if a template is found. Explanation: The original code had some unnecessary steps and nested conditions that increased the complexity. By removing the redundant list conversion and returning directly from the loop when a match is found, we simplify the control flow and reduce the cognitive complexity of the function. The simplified OCR fallback logic also contributes to reducing the complexity by avoiding unnecessary nesting and making the code easier to follow. Added typehint for `Templates`. This fixes mypy error. Changes in ocrmypdf fallback: Renamed template to templates_matched: I renamed the template variable to templates_matched in the assignment to make it clearer that extract_data_fallback_ocrmypdf returns a list of templates. Checked for matched templates: I added a check if templates_matched: to ensure that at least one template matched before trying to access the first element. Assigned the first matched template: If templates_matched is not empty, I assign the first template in the list to the template variable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Superseeding #266