Support FLUX structural control LoRA models #7450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
python
RyanJDick
requested review from
psychedelicious,
blessedcoolant,
maryhipp,
hipsterusername,
lstein and
brandonrising
as code owners
6 tasks
…rt 1 structural lora per transformer. various other refractors and bugfixes
…anging the modules in the transformer model
…ault settings for preprocessor in probe
…isplay default settings in model manager
psychedelicious
force-pushed
the
brandon/flux-tools-loras
branch
from
6c3281c to
c358a63
Compare
psychedelicious
approved these changes
Dec 17, 2024
hipsterusername
approved these changes
Dec 17, 2024
RyanJDick
added a commit
that referenced
this pull request
Dec 17, 2024
## Summary Add the ability to control the weight of a FLUX Control LoRA. ## Example Original image: <div style="display: flex; gap: 10px;"> <img src="https://github.com/user-attachments/assets/4a2d9f4a-b58b-4df6-af90-67b018763a38" alt="Image 1" width="300"/> </div> Prompt: `a scarecrow playing tennis` Weights: 0.4, 0.6, 0.8, 1.0 <div style="display: flex; gap: 10px;"> <img src="https://github.com/user-attachments/assets/62b83fd6-46ce-460a-8d51-9c2cda9b05c9" alt="Image 1" width="300"/> <img src="https://github.com/user-attachments/assets/75442207-1538-46bc-9d6b-08ac5c235c93" alt="Image 2" width="300"/> </div> <div style="display: flex; gap: 10px;"> <img src="https://github.com/user-attachments/assets/4a9dc9ea-9757-4965-837e-197fc9243007" alt="Image 1" width="300"/> <img src="https://github.com/user-attachments/assets/846f6918-ca82-4482-8c19-19172752fa8c" alt="Image 2" width="300"/> </div> ## QA Instructions - [x] weight control changes strength of control image - [x] Test that results match across both quantized and non-quantized. ## Merge Plan **_Do not merge this PR yet._** 1. Merge #7450 2. Merge #7446 3. Change target branch to main 4. Merge this branch. ## Checklist - [ ] _The PR has a short but descriptive title, suitable for a changelog_ - [ ] _Tests added / updated (if applicable)_ - [ ] _Documentation added / updated (if applicable)_ - [ ] _Updated `What's New` copy (if doing a release after this PR)_
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for the FLUX structural control LoRA models:
Note: Experimentally, the depth control model was found to be much more effective than the canny control model.
Left for future
Example flux1-depth-dev-lora
Input image:
Prompt:
a scarecrow playing tennisOutput:
QA Instructions
Remaining TODOs
Checklist
What's Newcopy (if doing a release after this PR)